revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-15 09:11:07 +01:00
Code Issues Releases Wiki Activity

Normalize spacing around empty object lists

Browse source 
Summary: Adds an li for semantics, fixes spacing around error view in a phui-box or not

Test Plan: view a project with no tasks, perform a search with no data returned.

Reviewers: epriestley

Reviewed By: epriestley

CC: Korvin, epriestley, aran

Differential Revision: https://secure.phabricator.com/D8371
This commit is contained in:
Chad Little 2014-02-28 11:16:11 -08:00
parent 3a188de328
commit 05607aedf9
3 changed files with 12 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
resources/celerity/map.php
View file

@ -7,7 +7,7 @@
return array( return array(
'names' => 'names' =>
array( array(
'core.pkg.css' => 'f12d87a6', 'core.pkg.css' => '7c181600',
'core.pkg.js' => 'b7bdab05', 'core.pkg.js' => 'b7bdab05',
'darkconsole.pkg.js' => 'ca8671ce', 'darkconsole.pkg.js' => 'ca8671ce',
'differential.pkg.css' => 'd1b3a605', 'differential.pkg.css' => 'd1b3a605',
@ -138,7 +138,7 @@ return array(
'rsrc/css/phui/phui-info-panel.css' => '27ea50a1', 'rsrc/css/phui/phui-info-panel.css' => '27ea50a1',
'rsrc/css/phui/phui-list.css' => '2edb76cf', 'rsrc/css/phui/phui-list.css' => '2edb76cf',
'rsrc/css/phui/phui-object-box.css' => 'ce92d8ec', 'rsrc/css/phui/phui-object-box.css' => 'ce92d8ec',
'rsrc/css/phui/phui-object-item-list-view.css' => 'eb579d6c', 'rsrc/css/phui/phui-object-item-list-view.css' => '4e4e3d4c',
'rsrc/css/phui/phui-pinboard-view.css' => '4b346c2a', 'rsrc/css/phui/phui-pinboard-view.css' => '4b346c2a',
'rsrc/css/phui/phui-property-list-view.css' => 'dbf53b12', 'rsrc/css/phui/phui-property-list-view.css' => 'dbf53b12',
'rsrc/css/phui/phui-remarkup-preview.css' => '19ad512b', 'rsrc/css/phui/phui-remarkup-preview.css' => '19ad512b',
@ -753,7 +753,7 @@ return array(
'phui-info-panel-css' => '27ea50a1', 'phui-info-panel-css' => '27ea50a1',
'phui-list-view-css' => '2edb76cf', 'phui-list-view-css' => '2edb76cf',
'phui-object-box-css' => 'ce92d8ec', 'phui-object-box-css' => 'ce92d8ec',
'phui-object-item-list-view-css' => 'eb579d6c', 'phui-object-item-list-view-css' => '4e4e3d4c',
'phui-pinboard-view-css' => '4b346c2a', 'phui-pinboard-view-css' => '4b346c2a',
'phui-property-list-view-css' => 'dbf53b12', 'phui-property-list-view-css' => 'dbf53b12',
'phui-remarkup-preview-css' => '19ad512b', 'phui-remarkup-preview-css' => '19ad512b',

8
src/view/phui/PHUIObjectItemListView.php
View file

@ -107,9 +107,15 @@ final class PHUIObjectItemListView extends AphrontTagView {
$items = null; $items = null;
} else { } else {
$string = nonempty($this->noDataString, pht('No data.')); $string = nonempty($this->noDataString, pht('No data.'));
$items = id(new AphrontErrorView()) $string = id(new AphrontErrorView())
->setSeverity(AphrontErrorView::SEVERITY_NODATA) ->setSeverity(AphrontErrorView::SEVERITY_NODATA)
->appendChild($string); ->appendChild($string);
$items = phutil_tag(
'li',
array(
'class' => 'phui-object-item-empty'),
$string);
} }
$pager = null; $pager = null;

8
webroot/rsrc/css/phui/phui-object-item-list-view.css
View file

@ -29,7 +29,8 @@
} }
.phui-object-item-list-view .aphront-error-view { .phui-object-item-list-view .aphront-error-view {
margin: 0; margin: 4px 0 8px 0;
color: {$bluetext};
} }
.phui-object-item { .phui-object-item {
@ -415,11 +416,6 @@
background: {$lightblue}; background: {$lightblue};
} }
.phui-object-list-flush .aphront-error-view {
margin: 0;
background: #fff;
}
/* - Foot Icons ---------------------------------------------------------------- /* - Foot Icons ----------------------------------------------------------------