revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-19 12:00:55 +01:00
Code Issues Releases Wiki Activity

Fix a ModularTransactions exception with custom fields that support change details

Browse source 
Summary: We're throwing here when we actually want to return `null` so we make it into custom field handling code. See Conpherence.

Test Plan: Found a failing task and re-executed it with `bin/worker execute --id <id>`; after this change, it didn't fatal.

Reviewers: chad

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D17051
This commit is contained in:
epriestley 2016-12-13 17:45:34 -08:00
parent 7f99f2cde8
commit 0c6e03d5af
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/transactions/storage/PhabricatorModularTransactionType.php
View file

@ -68,7 +68,7 @@ abstract class PhabricatorModularTransactionType
} }
public function newChangeDetailView() { public function newChangeDetailView() {
throw new PhutilMethodNotImplementedException(); return null;
} }
public function getMailDiffSectionHeader() { public function getMailDiffSectionHeader() {