Remove "dateCommitted" field from DifferentialRevision

Summary: Ref T2222. This is obsolete and no longer used. We could deduce it from transactions or commits in modern Phabricator if we wanted it. We may implement a more general mechanism for T4434.

Test Plan: `grep`

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2222

Differential Revision: https://secure.phabricator.com/D8330

resources/sql/autopatches/20140224.dxclean.1.datecommitted.sql

@@ -0,0 +1,2 @@
+ALTER TABLE {$NAMESPACE}_differential.differential_revision
+  DROP dateCommitted;

src/applications/differential/conduit/ConduitAPI_differential_close_Method.php

@@ -60,7 +60,6 @@ final class ConduitAPI_differential_close_Method
     $editor->save();
 
     $revision->setStatus(ArcanistDifferentialRevisionStatus::CLOSED);
-    $revision->setDateCommitted(time());
     $revision->save();
 
     return;

src/applications/differential/editor/DifferentialCommentEditor.php

@@ -409,10 +409,6 @@ final class DifferentialCommentEditor extends PhabricatorEditor {
           }
         }
 
-        if (!$revision->getDateCommitted()) {
-          $revision->setDateCommitted(time());
-        }
-
         $revision->setStatus(ArcanistDifferentialRevisionStatus::CLOSED);
         break;
 

src/applications/differential/editor/DifferentialTransactionEditor.php

@@ -143,11 +143,6 @@ final class DifferentialTransactionEditor
             // TODO: Update review status?
             break;
           case DifferentialAction::ACTION_CLOSE:
-            if (!$object->getDateCommitted()) {
-              // TODO: Can we remove this? It is probably no longer used by
-              // anything anymore. See also T4434.
-              $object->setDateCommitted(time());
-            }
             $object->setStatus(ArcanistDifferentialRevisionStatus::CLOSED);
             break;
           default:

src/applications/differential/storage/DifferentialRevision.php

@@ -20,8 +20,6 @@ final class DifferentialRevision extends DifferentialDAO
   protected $authorPHID;
   protected $lastReviewerPHID;
 
-  protected $dateCommitted;
-
   protected $lineCount = 0;
   protected $attached = array();
 

src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php

@@ -117,7 +117,6 @@ abstract class PhabricatorRepositoryCommitMessageParserWorker
 
           $diff = $this->attachToRevision($revision, $actor_phid);
 
-          $revision->setDateCommitted($commit->getEpoch());
           $editor = new DifferentialCommentEditor(
             $revision,
             DifferentialAction::ACTION_CLOSE);