revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-26 08:42:41 +01:00
Code Issues Releases Wiki Activity

Remove "dateCommitted" field from DifferentialRevision

Browse source 
Summary: Ref T2222. This is obsolete and no longer used. We could deduce it from transactions or commits in modern Phabricator if we wanted it. We may implement a more general mechanism for T4434.

Test Plan: `grep`

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2222

Differential Revision: https://secure.phabricator.com/D8330
This commit is contained in:
epriestley 2014-02-25 12:36:14 -08:00
parent 9292433dae
commit 0f0673b9e5
6 changed files with 2 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
resources/sql/autopatches/20140224.dxclean.1.datecommitted.sql Normal file
View file

@ -0,0 +1,2 @@
ALTER TABLE {$NAMESPACE}_differential.differential_revision
DROP dateCommitted;

1
src/applications/differential/conduit/ConduitAPI_differential_close_Method.php
View file

@ -60,7 +60,6 @@ final class ConduitAPI_differential_close_Method
$editor->save();
$revision->setStatus(ArcanistDifferentialRevisionStatus::CLOSED);
$revision->setDateCommitted(time());
$revision->save();
return;

4
src/applications/differential/editor/DifferentialCommentEditor.php
View file

@ -409,10 +409,6 @@ final class DifferentialCommentEditor extends PhabricatorEditor {
}
}
if (!$revision->getDateCommitted()) {
$revision->setDateCommitted(time());
}
$revision->setStatus(ArcanistDifferentialRevisionStatus::CLOSED);
break;

5
src/applications/differential/editor/DifferentialTransactionEditor.php
View file

@ -143,11 +143,6 @@ final class DifferentialTransactionEditor
// TODO: Update review status?
break;
case DifferentialAction::ACTION_CLOSE:
if (!$object->getDateCommitted()) {
// TODO: Can we remove this? It is probably no longer used by
// anything anymore. See also T4434.
$object->setDateCommitted(time());
}
$object->setStatus(ArcanistDifferentialRevisionStatus::CLOSED);
break;
default:

2
src/applications/differential/storage/DifferentialRevision.php
View file

@ -20,8 +20,6 @@ final class DifferentialRevision extends DifferentialDAO
protected $authorPHID;
protected $lastReviewerPHID;
protected $dateCommitted;
protected $lineCount = 0;
protected $attached = array();

1
src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php
View file

@ -117,7 +117,6 @@ abstract class PhabricatorRepositoryCommitMessageParserWorker
$diff = $this->attachToRevision($revision, $actor_phid);
$revision->setDateCommitted($commit->getEpoch());
$editor = new DifferentialCommentEditor(
$revision,
DifferentialAction::ACTION_CLOSE);