mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-23 05:50:55 +01:00
Fix small bugs regarding Maniphest Task <=> Differential Revision attachments
Summary: introduced in D3006, D3007. we need a list of phids for revision and now that its attachments its always two way. without this patch revisions don't show up on maniphest and attaching from either mani or diffu only has the attachment show up where you did it. (since two_way = false) Test Plan: attached revisions and tasks to one another and verified things were showing up where they should Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D3011
This commit is contained in:
parent
ae13d33859
commit
108ffb9e0a
2 changed files with 2 additions and 2 deletions
|
@ -180,7 +180,7 @@ final class ManiphestTaskDetailController extends ManiphestController {
|
|||
$revs = idx($attached, PhabricatorPHIDConstants::PHID_TYPE_DREV);
|
||||
if ($revs) {
|
||||
$dict['Revisions'] = $this->renderHandleList(
|
||||
array_select_keys($handles, $revs));
|
||||
array_select_keys($handles, array_keys($revs)));
|
||||
}
|
||||
|
||||
if ($commit_phids) {
|
||||
|
|
|
@ -104,7 +104,7 @@ final class PhabricatorSearchAttachController
|
|||
$editor->attachObjects(
|
||||
$attach_type,
|
||||
$phids,
|
||||
$two_way = false);
|
||||
$two_way = true);
|
||||
|
||||
return id(new AphrontReloadResponse())->setURI($handle->getURI());
|
||||
default:
|
||||
|
|
Loading…
Reference in a new issue