revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-27 01:02:42 +01:00
Code Issues Releases Wiki Activity

Fix small bugs regarding Maniphest Task <=> Differential Revision attachments

Browse source 
Summary:
introduced in D3006, D3007. we need a list of phids for revision and now that its attachments its always two way.

without this patch revisions don't show up on maniphest and attaching from either mani or diffu only has the attachment show up where you did it. (since two_way = false)

Test Plan: attached revisions and tasks to one another and verified things were showing up where they should

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D3011
This commit is contained in:
Bob Trahan 2012-07-19 09:44:23 -07:00
parent ae13d33859
commit 108ffb9e0a
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/maniphest/controller/ManiphestTaskDetailController.php
View file

@ -180,7 +180,7 @@ final class ManiphestTaskDetailController extends ManiphestController {
$revs = idx($attached, PhabricatorPHIDConstants::PHID_TYPE_DREV); $revs = idx($attached, PhabricatorPHIDConstants::PHID_TYPE_DREV);
if ($revs) { if ($revs) {
$dict['Revisions'] = $this->renderHandleList( $dict['Revisions'] = $this->renderHandleList(
array_select_keys($handles, $revs)); array_select_keys($handles, array_keys($revs)));
} }
if ($commit_phids) { if ($commit_phids) {

2
src/applications/search/controller/PhabricatorSearchAttachController.php
View file

@ -104,7 +104,7 @@ final class PhabricatorSearchAttachController
$editor->attachObjects( $editor->attachObjects(
$attach_type, $attach_type,
$phids, $phids,
$two_way = false); $two_way = true);
return id(new AphrontReloadResponse())->setURI($handle->getURI()); return id(new AphrontReloadResponse())->setURI($handle->getURI());
default: default: