mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-22 23:02:42 +01:00
Enable 'jumping to toc' on diffusion commit page
Summary: Diffusion page is sharing the keyboard shortcuts code with Differential page. But since the toc (Changes) panel doesn't have id 'differential-review-toc', the 'jumping to toc' doesn't work. The fix is to add the ID. I don't like adding 'Differential' to the Diffusion page. Later we should refactor the code to extract the shared components out of Differential. Test Plan: verified that 't' worked on the diffusion commit page. Reviewers: epriestley, nh Reviewed By: epriestley CC: hwang, aran, Korvin Differential Revision: https://secure.phabricator.com/D2500
This commit is contained in:
parent
fea67c9858
commit
112acf11cf
1 changed files with 1 additions and 0 deletions
|
@ -162,6 +162,7 @@ final class DiffusionCommitController extends DiffusionController {
|
|||
} else {
|
||||
$change_panel = new AphrontPanelView();
|
||||
$change_panel->setHeader("Changes (".number_format($count).")");
|
||||
$change_panel->setID('differential-review-toc');
|
||||
|
||||
if ($count !== $original_changes_count) {
|
||||
$show_all_button = phutil_render_tag(
|
||||
|
|
Loading…
Reference in a new issue