mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-29 17:00:59 +01:00
Remove "pretag" hook support in Mercurial
Summary: Ref T4195. This doesn't actually work like I thought it did: it only fires locally, when you run `hg tag`. Mercurial tags are also weird and basically don't make any sense and everyone should use bookmarks instead. We could implement some flavor of this eventually, but I'd like to see users request it first. They can implement their own with content-based hooks once those work, anyway. Test Plan: This code didn't do anything. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T4195 Differential Revision: https://secure.phabricator.com/D7765
This commit is contained in:
parent
b326ef5947
commit
11b8e57ae0
2 changed files with 0 additions and 12 deletions
|
@ -432,8 +432,6 @@ final class DiffusionCommitHookEngine extends Phobject {
|
|||
return $this->findMercurialChangegroupRefUpdates();
|
||||
case 'prepushkey':
|
||||
return $this->findMercurialPushKeyRefUpdates();
|
||||
case 'pretag':
|
||||
return $this->findMercurialPreTagRefUpdates();
|
||||
default:
|
||||
throw new Exception(pht('Unrecognized hook "%s"!', $hook));
|
||||
}
|
||||
|
@ -693,10 +691,6 @@ final class DiffusionCommitHookEngine extends Phobject {
|
|||
return array($ref_update);
|
||||
}
|
||||
|
||||
private function findMercurialPreTagRefUpdates() {
|
||||
return array();
|
||||
}
|
||||
|
||||
private function findMercurialContentUpdates(array $ref_updates) {
|
||||
// TODO: Implement.
|
||||
return array();
|
||||
|
|
|
@ -412,12 +412,6 @@ final class PhabricatorRepositoryPullEngine
|
|||
$repository->getCallsign(),
|
||||
'prepushkey');
|
||||
|
||||
// This one handles creating tags.
|
||||
$data[] = csprintf(
|
||||
'pretag.phabricator = %s %s %s',
|
||||
$bin,
|
||||
$repository->getCallsign(),
|
||||
'pretag');
|
||||
$data[] = null;
|
||||
|
||||
$data = implode("\n", $data);
|
||||
|
|
Loading…
Reference in a new issue