revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-30 01:10:58 +01:00
Code Issues Releases Wiki Activity

Add "final" to more classes

Browse source 
Summary: No big surprises here, delted the unused "DarkConsole" class.

Test Plan: Ran 'testEverythingImplemented' to verify I wasn't finalizing anything we extend.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran, epriestley

Maniphest Tasks: T795

Differential Revision: https://secure.phabricator.com/D1876
This commit is contained in:
epriestley 2012-03-13 11:18:11 -07:00
parent 49366559af
commit 11cccb98c2
126 changed files with 222 additions and 229 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/__phutil_library_map__.php
View file

@ -169,7 +169,6 @@ phutil_register_library_map(array(
'ConduitAPI_user_info_Method' => 'applications/conduit/method/user/info', 'ConduitAPI_user_info_Method' => 'applications/conduit/method/user/info',
'ConduitAPI_user_whoami_Method' => 'applications/conduit/method/user/whoami', 'ConduitAPI_user_whoami_Method' => 'applications/conduit/method/user/whoami',
'ConduitException' => 'applications/conduit/protocol/exception', 'ConduitException' => 'applications/conduit/protocol/exception',
'DarkConsole' => 'aphront/console/api',
'DarkConsoleConfigPlugin' => 'aphront/console/plugin/config', 'DarkConsoleConfigPlugin' => 'aphront/console/plugin/config',
'DarkConsoleController' => 'aphront/console/controller', 'DarkConsoleController' => 'aphront/console/controller',
'DarkConsoleCore' => 'aphront/console/core', 'DarkConsoleCore' => 'aphront/console/core',

24
src/aphront/console/api/DarkConsole.php
View file

@ -1,24 +0,0 @@
<?php
/*
* Copyright 2011 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
/**
* @group console
*/
class DarkConsole {
}

10
src/aphront/console/api/__init__.php
View file

@ -1,10 +0,0 @@
<?php
/**
* This file is automatically generated. Lint this module to rebuild it.
* @generated
*/
phutil_require_source('DarkConsole.php');

4
src/aphront/console/plugin/config/DarkConsoleConfigPlugin.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/** /**
* @group console * @group console
*/ */
class DarkConsoleConfigPlugin extends DarkConsolePlugin { final class DarkConsoleConfigPlugin extends DarkConsolePlugin {
public function getName() { public function getName() {
return 'Config'; return 'Config';

4
src/aphront/console/plugin/errorlog/DarkConsoleErrorLogPlugin.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/** /**
* @group console * @group console
*/ */
class DarkConsoleErrorLogPlugin extends DarkConsolePlugin { final class DarkConsoleErrorLogPlugin extends DarkConsolePlugin {
public function getName() { public function getName() {
$count = count($this->getData()); $count = count($this->getData());

4
src/aphront/console/plugin/errorlog/api/DarkConsoleErrorLogPluginAPI.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/** /**
* @group console * @group console
*/ */
class DarkConsoleErrorLogPluginAPI { final class DarkConsoleErrorLogPluginAPI {
private static $errors = array(); private static $errors = array();

4
src/aphront/console/plugin/event/DarkConsoleEventPlugin.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/** /**
* @group console * @group console
*/ */
class DarkConsoleEventPlugin extends DarkConsolePlugin { final class DarkConsoleEventPlugin extends DarkConsolePlugin {
public function getName() { public function getName() {
return 'Events'; return 'Events';

4
src/aphront/console/plugin/event/api/DarkConsoleEventPluginAPI.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/** /**
* @group console * @group console
*/ */
class DarkConsoleEventPluginAPI extends PhutilEventListener { final class DarkConsoleEventPluginAPI extends PhutilEventListener {
private static $events = array(); private static $events = array();
private static $discardMode = false; private static $discardMode = false;

4
src/aphront/console/plugin/request/DarkConsoleRequestPlugin.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/** /**
* @group console * @group console
*/ */
class DarkConsoleRequestPlugin extends DarkConsolePlugin { final class DarkConsoleRequestPlugin extends DarkConsolePlugin {
public function getName() { public function getName() {
return 'Request'; return 'Request';

2
src/aphront/console/plugin/services/DarkConsoleServicesPlugin.php
View file

@ -19,7 +19,7 @@
/** /**
* @group console * @group console
*/ */
class DarkConsoleServicesPlugin extends DarkConsolePlugin { final class DarkConsoleServicesPlugin extends DarkConsolePlugin {
protected $observations; protected $observations;

4
src/aphront/console/plugin/xhprof/DarkConsoleXHProfPlugin.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/** /**
* @group console * @group console
*/ */
class DarkConsoleXHProfPlugin extends DarkConsolePlugin { final class DarkConsoleXHProfPlugin extends DarkConsolePlugin {
protected $xhprofID; protected $xhprofID;

4
src/aphront/exception/base/AphrontException.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -16,6 +16,6 @@
* limitations under the License. * limitations under the License.
*/ */
class AphrontException extends Exception { abstract class AphrontException extends Exception {
} }

4
src/aphront/exception/csrf/AphrontCSRFException.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -16,6 +16,6 @@
* limitations under the License. * limitations under the License.
*/ */
class AphrontCSRFException extends AphrontException { final class AphrontCSRFException extends AphrontException {
} }

7
src/aphront/exception/redirect/AphrontRedirectException.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -16,7 +16,10 @@
* limitations under the License. * limitations under the License.
*/ */
class AphrontRedirectException extends AphrontException { /**
* TODO: Remove this entirely? We have no callsites.
*/
final class AphrontRedirectException extends AphrontException {
private $uri; private $uri;

2
src/aphront/request/AphrontRequest.php
View file

@ -22,7 +22,7 @@
* *
* @group aphront * @group aphront
*/ */
class AphrontRequest { final class AphrontRequest {
const TYPE_AJAX = '__ajax__'; const TYPE_AJAX = '__ajax__';
const TYPE_FORM = '__form__'; const TYPE_FORM = '__form__';

2
src/aphront/request/__tests__/AphrontRequestTestCase.php
View file

@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class AphrontRequestTestCase extends PhabricatorTestCase { final class AphrontRequestTestCase extends PhabricatorTestCase {
public function testRequestDataAccess() { public function testRequestDataAccess() {
$r = new AphrontRequest('http://example.com/', '/'); $r = new AphrontRequest('http://example.com/', '/');

4
src/aphront/response/304/Aphront304Response.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/** /**
* @group aphront * @group aphront
*/ */
class Aphront304Response extends AphrontResponse { final class Aphront304Response extends AphrontResponse {
public function getHTTPResponseCode() { public function getHTTPResponseCode() {
return 304; return 304;

4
src/aphront/response/400/Aphront400Response.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/** /**
* @group aphront * @group aphront
*/ */
class Aphront400Response extends AphrontResponse { final class Aphront400Response extends AphrontResponse {
public function getHTTPResponseCode() { public function getHTTPResponseCode() {
return 400; return 400;

2
src/aphront/response/403/Aphront403Response.php
View file

@ -19,7 +19,7 @@
/** /**
* @group aphront * @group aphront
*/ */
class Aphront403Response extends AphrontWebpageResponse { final class Aphront403Response extends AphrontWebpageResponse {
private $forbiddenText; private $forbiddenText;
public function setForbiddenText($text) { public function setForbiddenText($text) {

2
src/aphront/response/404/Aphront404Response.php
View file

@ -19,7 +19,7 @@
/** /**
* @group aphront * @group aphront
*/ */
class Aphront404Response extends AphrontWebpageResponse { final class Aphront404Response extends AphrontWebpageResponse {
public function getHTTPResponseCode() { public function getHTTPResponseCode() {
return 404; return 404;

2
src/aphront/response/file/AphrontFileResponse.php
View file

@ -19,7 +19,7 @@
/** /**
* @group aphront * @group aphront
*/ */
class AphrontFileResponse extends AphrontResponse { final class AphrontFileResponse extends AphrontResponse {
private $content; private $content;
private $mimeType; private $mimeType;

2
src/aphront/response/plaintext/AphrontPlainTextResponse.php
View file

@ -19,7 +19,7 @@
/** /**
* @group aphront * @group aphront
*/ */
class AphrontPlainTextResponse extends AphrontResponse { final class AphrontPlainTextResponse extends AphrontResponse {
public function setContent($content) { public function setContent($content) {
$this->content = $content; $this->content = $content;

4
src/aphront/response/redirect/AphrontRedirectResponse.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -17,6 +17,8 @@
*/ */
/** /**
* TODO: Should be final but isn't because of AphrontReloadResponse.
*
* @group aphront * @group aphront
*/ */
class AphrontRedirectResponse extends AphrontResponse { class AphrontRedirectResponse extends AphrontResponse {

4
src/aphront/response/reload/AphrontReloadResponse.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -24,7 +24,7 @@
* *
* @group aphront * @group aphront
*/ */
class AphrontReloadResponse extends AphrontRedirectResponse { final class AphrontReloadResponse extends AphrontRedirectResponse {
public function getURI() { public function getURI() {
if ($this->getRequest()->isAjax()) { if ($this->getRequest()->isAjax()) {

4
src/aphront/response/webpage/AphrontWebpageResponse.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -17,6 +17,8 @@
*/ */
/** /**
* TODO: Should be final, but isn't because of Aphront403Response / 404Response.
*
* @group aphront * @group aphront
*/ */
class AphrontWebpageResponse extends AphrontResponse { class AphrontWebpageResponse extends AphrontResponse {

4
src/applications/audit/storage/auditcomment/PhabricatorAuditComment.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class PhabricatorAuditComment extends PhabricatorAuditDAO { final class PhabricatorAuditComment extends PhabricatorAuditDAO {
protected $phid; protected $phid;
protected $actorPHID; protected $actorPHID;

2
src/applications/auth/oauth/provider/facebook/PhabricatorOAuthProviderFacebook.php
View file

@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class PhabricatorOAuthProviderFacebook extends PhabricatorOAuthProvider { final class PhabricatorOAuthProviderFacebook extends PhabricatorOAuthProvider {
private $userData; private $userData;

2
src/applications/auth/oauth/provider/github/PhabricatorOAuthProviderGitHub.php
View file

@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class PhabricatorOAuthProviderGitHub extends PhabricatorOAuthProvider { final class PhabricatorOAuthProviderGitHub extends PhabricatorOAuthProvider {
private $userData; private $userData;

2
src/applications/auth/oauth/provider/google/PhabricatorOAuthProviderGoogle.php
View file

@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class PhabricatorOAuthProviderGoogle extends PhabricatorOAuthProvider { final class PhabricatorOAuthProviderGoogle extends PhabricatorOAuthProvider {
private $userData; private $userData;

2
src/applications/auth/view/oauthfailure/PhabricatorOAuthFailureView.php
View file

@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class PhabricatorOAuthFailureView extends AphrontView { final class PhabricatorOAuthFailureView extends AphrontView {
private $request; private $request;
private $provider; private $provider;

4
src/applications/conduit/method/arcanist/projectinfo/ConduitAPI_arcanist_projectinfo_Method.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/** /**
* @group conduit * @group conduit
*/ */
class ConduitAPI_arcanist_projectinfo_Method final class ConduitAPI_arcanist_projectinfo_Method
extends ConduitAPI_arcanist_Method { extends ConduitAPI_arcanist_Method {
public function getMethodDescription() { public function getMethodDescription() {

4
src/applications/conduit/method/conduit/connect/ConduitAPI_conduit_connect_Method.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/** /**
* @group conduit * @group conduit
*/ */
class ConduitAPI_conduit_connect_Method extends ConduitAPIMethod { final class ConduitAPI_conduit_connect_Method extends ConduitAPIMethod {
public function shouldRequireAuthentication() { public function shouldRequireAuthentication() {
return false; return false;

4
src/applications/conduit/method/conduit/getcertificate/ConduitAPI_conduit_getcertificate_Method.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/** /**
* @group conduit * @group conduit
*/ */
class ConduitAPI_conduit_getcertificate_Method extends ConduitAPIMethod { final class ConduitAPI_conduit_getcertificate_Method extends ConduitAPIMethod {
public function shouldRequireAuthentication() { public function shouldRequireAuthentication() {
return false; return false;

4
src/applications/conduit/method/conduit/ping/ConduitAPI_conduit_ping_Method.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/** /**
* @group conduit * @group conduit
*/ */
class ConduitAPI_conduit_ping_Method extends ConduitAPIMethod { final class ConduitAPI_conduit_ping_Method extends ConduitAPIMethod {
public function shouldRequireAuthentication() { public function shouldRequireAuthentication() {
return false; return false;

4
src/applications/conduit/method/daemon/launched/ConduitAPI_daemon_launched_Method.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/** /**
* @group conduit * @group conduit
*/ */
class ConduitAPI_daemon_launched_Method extends ConduitAPIMethod { final class ConduitAPI_daemon_launched_Method extends ConduitAPIMethod {
public function shouldRequireAuthentication() { public function shouldRequireAuthentication() {
// TODO: Lock this down once we build phantoms. // TODO: Lock this down once we build phantoms.

4
src/applications/conduit/method/daemon/log/ConduitAPI_daemon_log_Method.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/** /**
* @group conduit * @group conduit
*/ */
class ConduitAPI_daemon_log_Method extends ConduitAPIMethod { final class ConduitAPI_daemon_log_Method extends ConduitAPIMethod {
public function shouldRequireAuthentication() { public function shouldRequireAuthentication() {
// TODO: Lock this down once we build phantoms. // TODO: Lock this down once we build phantoms.

5
src/applications/conduit/method/differential/createcomment/ConduitAPI_differential_createcomment_Method.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -19,7 +19,8 @@
/** /**
* @group conduit * @group conduit
*/ */
class ConduitAPI_differential_createcomment_Method extends ConduitAPIMethod { final class ConduitAPI_differential_createcomment_Method
extends ConduitAPIMethod {
public function getMethodDescription() { public function getMethodDescription() {
return "Add a comment to a Differential revision."; return "Add a comment to a Differential revision.";

2
src/applications/conduit/method/differential/creatediff/ConduitAPI_differential_creatediff_Method.php
View file

@ -19,7 +19,7 @@
/** /**
* @group conduit * @group conduit
*/ */
class ConduitAPI_differential_creatediff_Method extends ConduitAPIMethod { final class ConduitAPI_differential_creatediff_Method extends ConduitAPIMethod {
public function getMethodDescription() { public function getMethodDescription() {
return "Create a new Differential diff."; return "Create a new Differential diff.";

5
src/applications/conduit/method/differential/createrevision/ConduitAPI_differential_createrevision_Method.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -19,7 +19,8 @@
/** /**
* @group conduit * @group conduit
*/ */
class ConduitAPI_differential_createrevision_Method extends ConduitAPIMethod { final class ConduitAPI_differential_createrevision_Method
extends ConduitAPIMethod {
public function getMethodDescription() { public function getMethodDescription() {
return "Create a new Differential revision."; return "Create a new Differential revision.";

2
src/applications/conduit/method/differential/find/ConduitAPI_differential_find_Method.php
View file

@ -19,7 +19,7 @@
/** /**
* @group conduit * @group conduit
*/ */
class ConduitAPI_differential_find_Method extends ConduitAPIMethod { final class ConduitAPI_differential_find_Method extends ConduitAPIMethod {
public function getMethodDescription() { public function getMethodDescription() {
return "Query Differential revisions which match certain criteria."; return "Query Differential revisions which match certain criteria.";

5
src/applications/conduit/method/differential/getalldiffs/ConduitAPI_differential_getalldiffs_Method.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -19,7 +19,8 @@
/** /**
* @group conduit * @group conduit
*/ */
class ConduitAPI_differential_getalldiffs_Method extends ConduitAPIMethod { final class ConduitAPI_differential_getalldiffs_Method
extends ConduitAPIMethod {
public function getMethodDescription() { public function getMethodDescription() {
return "Load all diffs for given revisions from Differential."; return "Load all diffs for given revisions from Differential.";

3
src/applications/conduit/method/differential/getcommitmessage/ConduitAPI_differential_getcommitmessage_Method.php
View file

@ -19,7 +19,8 @@
/** /**
* @group conduit * @group conduit
*/ */
class ConduitAPI_differential_getcommitmessage_Method extends ConduitAPIMethod { final class ConduitAPI_differential_getcommitmessage_Method
extends ConduitAPIMethod {
public function getMethodDescription() { public function getMethodDescription() {
return "Retrieve Differential commit messages or message templates."; return "Retrieve Differential commit messages or message templates.";

5
src/applications/conduit/method/differential/getcommitpaths/ConduitAPI_differential_getcommitpaths_Method.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -19,7 +19,8 @@
/** /**
* @group conduit * @group conduit
*/ */
class ConduitAPI_differential_getcommitpaths_Method extends ConduitAPIMethod { final class ConduitAPI_differential_getcommitpaths_Method
extends ConduitAPIMethod {
public function getMethodDescription() { public function getMethodDescription() {
return "Query which paths should be included when committing a ". return "Query which paths should be included when committing a ".

4
src/applications/conduit/method/differential/getdiff/ConduitAPI_differential_getdiff_Method.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/** /**
* @group conduit * @group conduit
*/ */
class ConduitAPI_differential_getdiff_Method extends ConduitAPIMethod { final class ConduitAPI_differential_getdiff_Method extends ConduitAPIMethod {
public function getMethodDescription() { public function getMethodDescription() {
return "Load the content of a diff from Differential."; return "Load the content of a diff from Differential.";

3
src/applications/conduit/method/differential/getrevision/ConduitAPI_differential_getrevision_Method.php
View file

@ -19,7 +19,8 @@
/** /**
* @group conduit * @group conduit
*/ */
class ConduitAPI_differential_getrevision_Method extends ConduitAPIMethod { final class ConduitAPI_differential_getrevision_Method
extends ConduitAPIMethod {
public function getMethodDescription() { public function getMethodDescription() {
return "Load the content of a revision from Differential."; return "Load the content of a revision from Differential.";

4
src/applications/conduit/method/differential/getrevisioncomments/ConduitAPI_differential_getrevisioncomments_Method.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/** /**
* @group conduit * @group conduit
*/ */
class ConduitAPI_differential_getrevisioncomments_Method final class ConduitAPI_differential_getrevisioncomments_Method
extends ConduitAPIMethod { extends ConduitAPIMethod {
public function getMethodDescription() { public function getMethodDescription() {

4
src/applications/conduit/method/differential/getrevisionfeedback/ConduitAPI_differential_getrevisionfeedback_Method.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/** /**
* @group conduit * @group conduit
*/ */
class ConduitAPI_differential_getrevisionfeedback_Method final class ConduitAPI_differential_getrevisionfeedback_Method
extends ConduitAPIMethod { extends ConduitAPIMethod {
public function getMethodDescription() { public function getMethodDescription() {

3
src/applications/conduit/method/differential/markcommitted/ConduitAPI_differential_markcommitted_Method.php
View file

@ -19,7 +19,8 @@
/** /**
* @group conduit * @group conduit
*/ */
class ConduitAPI_differential_markcommitted_Method extends ConduitAPIMethod { final class ConduitAPI_differential_markcommitted_Method
extends ConduitAPIMethod {
public function getMethodDescription() { public function getMethodDescription() {
return "Mark Differential revisions as committed."; return "Mark Differential revisions as committed.";

2
src/applications/conduit/method/differential/parsecommitmessage/ConduitAPI_differential_parsecommitmessage_Method.php
View file

@ -19,7 +19,7 @@
/** /**
* @group conduit * @group conduit
*/ */
class ConduitAPI_differential_parsecommitmessage_Method final class ConduitAPI_differential_parsecommitmessage_Method
extends ConduitAPIMethod { extends ConduitAPIMethod {
public function getMethodDescription() { public function getMethodDescription() {

3
src/applications/conduit/method/differential/query/ConduitAPI_differential_query_Method.php
View file

@ -19,7 +19,8 @@
/** /**
* @group conduit * @group conduit
*/ */
class ConduitAPI_differential_query_Method extends ConduitAPIMethod { final class ConduitAPI_differential_query_Method
extends ConduitAPIMethod {
public function getMethodDescription() { public function getMethodDescription() {
return "Query Differential revisions which match certain criteria."; return "Query Differential revisions which match certain criteria.";

5
src/applications/conduit/method/differential/setdiffproperty/ConduitAPI_differential_setdiffproperty_Method.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -19,7 +19,8 @@
/** /**
* @group conduit * @group conduit
*/ */
class ConduitAPI_differential_setdiffproperty_Method extends ConduitAPIMethod { final class ConduitAPI_differential_setdiffproperty_Method
extends ConduitAPIMethod {
public function getMethodDescription() { public function getMethodDescription() {
return "Attach properties to Differential diffs."; return "Attach properties to Differential diffs.";

3
src/applications/conduit/method/differential/updaterevision/ConduitAPI_differential_updaterevision_Method.php
View file

@ -19,7 +19,8 @@
/** /**
* @group conduit * @group conduit
*/ */
class ConduitAPI_differential_updaterevision_Method extends ConduitAPIMethod { final class ConduitAPI_differential_updaterevision_Method
extends ConduitAPIMethod {
public function getMethodDescription() { public function getMethodDescription() {
return "Update a Differential revision."; return "Update a Differential revision.";

4
src/applications/conduit/method/differential/updatetaskrevisionassoc/ConduitAPI_differential_updatetaskrevisionassoc_Method.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/** /**
* @group conduit * @group conduit
*/ */
class ConduitAPI_differential_updatetaskrevisionassoc_Method final class ConduitAPI_differential_updatetaskrevisionassoc_Method
extends ConduitAPIMethod { extends ConduitAPIMethod {
public function getMethodDescription() { public function getMethodDescription() {

4
src/applications/conduit/method/differential/updateunitresults/ConduitAPI_differential_updateunitresults_Method.php
View file

@ -19,8 +19,8 @@
/** /**
* @group conduit * @group conduit
*/ */
class ConduitAPI_differential_updateunitresults_Method final class ConduitAPI_differential_updateunitresults_Method
extends ConduitAPIMethod { extends ConduitAPIMethod {
public function getMethodDescription() { public function getMethodDescription() {
return "Update arc unit results for a postponed test."; return "Update arc unit results for a postponed test.";

5
src/applications/conduit/method/diffusion/findsymbols/ConduitAPI_diffusion_findsymbols_Method.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -19,7 +19,8 @@
/** /**
* @group conduit * @group conduit
*/ */
class ConduitAPI_diffusion_findsymbols_Method extends ConduitAPIMethod { final class ConduitAPI_diffusion_findsymbols_Method
extends ConduitAPIMethod {
public function getMethodDescription() { public function getMethodDescription() {
return "Retrieve Diffusion symbol information."; return "Retrieve Diffusion symbol information.";

5
src/applications/conduit/method/diffusion/getcommits/ConduitAPI_diffusion_getcommits_Method.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -19,7 +19,8 @@
/** /**
* @group conduit * @group conduit
*/ */
class ConduitAPI_diffusion_getcommits_Method extends ConduitAPIMethod { final class ConduitAPI_diffusion_getcommits_Method
extends ConduitAPIMethod {
public function getMethodDescription() { public function getMethodDescription() {
return "Retrieve Diffusion commit information."; return "Retrieve Diffusion commit information.";

4
src/applications/conduit/method/diffusion/getrecentcommitsbypath/ConduitAPI_diffusion_getrecentcommitsbypath_Method.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/** /**
* @group conduit * @group conduit
*/ */
class ConduitAPI_diffusion_getrecentcommitsbypath_Method final class ConduitAPI_diffusion_getrecentcommitsbypath_Method
extends ConduitAPIMethod { extends ConduitAPIMethod {
const RESULT_LIMIT = 10; const RESULT_LIMIT = 10;

5
src/applications/conduit/method/feed/publish/ConduitAPI_feed_publish_Method.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -19,7 +19,8 @@
/** /**
* @group conduit * @group conduit
*/ */
class ConduitAPI_feed_publish_Method extends ConduitAPIMethod { final class ConduitAPI_feed_publish_Method
extends ConduitAPIMethod {
public function getMethodDescription() { public function getMethodDescription() {
return "(UNSTABLE!!!) Publish a story to the feed."; return "(UNSTABLE!!!) Publish a story to the feed.";

5
src/applications/conduit/method/file/download/ConduitAPI_file_download_Method.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -19,7 +19,8 @@
/** /**
* @group conduit * @group conduit
*/ */
class ConduitAPI_file_download_Method extends ConduitAPIMethod { final class ConduitAPI_file_download_Method
extends ConduitAPIMethod {
public function getMethodDescription() { public function getMethodDescription() {
return "Download a file from the server."; return "Download a file from the server.";

4
src/applications/conduit/method/file/info/ConduitAPI_file_info_Method.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/** /**
* @group conduit * @group conduit
*/ */
class ConduitAPI_file_info_Method extends ConduitAPIMethod { final class ConduitAPI_file_info_Method extends ConduitAPIMethod {
public function getMethodDescription() { public function getMethodDescription() {
return "Get information about a file."; return "Get information about a file.";

4
src/applications/conduit/method/file/upload/ConduitAPI_file_upload_Method.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/** /**
* @group conduit * @group conduit
*/ */
class ConduitAPI_file_upload_Method extends ConduitAPIMethod { final class ConduitAPI_file_upload_Method extends ConduitAPIMethod {
public function getMethodDescription() { public function getMethodDescription() {
return "Upload a file to the server."; return "Upload a file to the server.";

2
src/applications/conduit/method/maniphest/gettasktransactions/ConduitAPI_maniphest_gettasktransactions_Method.php
View file

@ -19,7 +19,7 @@
/** /**
* @group maniphest * @group maniphest
*/ */
class ConduitAPI_maniphest_gettasktransactions_Method final class ConduitAPI_maniphest_gettasktransactions_Method
extends ConduitAPI_maniphest_Method { extends ConduitAPI_maniphest_Method {
public function getMethodDescription() { public function getMethodDescription() {

4
src/applications/conduit/method/paste/create/ConduitAPI_paste_create_Method.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/** /**
* @group conduit * @group conduit
*/ */
class ConduitAPI_paste_create_Method extends ConduitAPI_paste_Method { final class ConduitAPI_paste_create_Method extends ConduitAPI_paste_Method {
public function getMethodDescription() { public function getMethodDescription() {
return 'Create a new paste.'; return 'Create a new paste.';

4
src/applications/conduit/method/paste/info/ConduitAPI_paste_info_Method.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/** /**
* @group conduit * @group conduit
*/ */
class ConduitAPI_paste_info_Method extends ConduitAPI_paste_Method { final class ConduitAPI_paste_info_Method extends ConduitAPI_paste_Method {
public function getMethodDescription() { public function getMethodDescription() {
return "Retrieve an array of information about a paste."; return "Retrieve an array of information about a paste.";

4
src/applications/conduit/method/path/getowners/ConduitAPI_path_getowners_Method.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/** /**
* @group conduit * @group conduit
*/ */
class ConduitAPI_path_getowners_Method extends ConduitAPIMethod { final class ConduitAPI_path_getowners_Method extends ConduitAPIMethod {
public function getMethodDescription() { public function getMethodDescription() {
return "Find the Owners package that contains a given path."; return "Find the Owners package that contains a given path.";

4
src/applications/conduit/method/phriction/edit/ConduitAPI_phriction_edit_Method.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/** /**
* @group conduit * @group conduit
*/ */
class ConduitAPI_phriction_edit_Method final class ConduitAPI_phriction_edit_Method
extends ConduitAPI_phriction_Method { extends ConduitAPI_phriction_Method {
public function getMethodDescription() { public function getMethodDescription() {

4
src/applications/conduit/method/phriction/history/ConduitAPI_phriction_history_Method.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/** /**
* @group conduit * @group conduit
*/ */
class ConduitAPI_phriction_history_Method final class ConduitAPI_phriction_history_Method
extends ConduitAPI_phriction_Method { extends ConduitAPI_phriction_Method {
public function getMethodDescription() { public function getMethodDescription() {

4
src/applications/conduit/method/phriction/info/ConduitAPI_phriction_info_Method.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/** /**
* @group conduit * @group conduit
*/ */
class ConduitAPI_phriction_info_Method final class ConduitAPI_phriction_info_Method
extends ConduitAPI_phriction_Method { extends ConduitAPI_phriction_Method {
public function getMethodDescription() { public function getMethodDescription() {

4
src/applications/conduit/method/slowvote/info/ConduitAPI_slowvote_info_Method.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/** /**
* @group conduit * @group conduit
*/ */
class ConduitAPI_slowvote_info_Method extends ConduitAPIMethod { final class ConduitAPI_slowvote_info_Method extends ConduitAPIMethod {
public function getMethodDescription() { public function getMethodDescription() {
return "Retrieve an array of information about a poll."; return "Retrieve an array of information about a poll.";

4
src/applications/conduit/protocol/exception/ConduitException.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/** /**
* @group conduit * @group conduit
*/ */
class ConduitException extends Exception { final class ConduitException extends Exception {
private $errorDescription; private $errorDescription;

2
src/applications/conduit/protocol/request/ConduitAPIRequest.php
View file

@ -19,7 +19,7 @@
/** /**
* @group conduit * @group conduit
*/ */
class ConduitAPIRequest { final class ConduitAPIRequest {
protected $params; protected $params;
private $user; private $user;

2
src/applications/conduit/protocol/response/ConduitAPIResponse.php
View file

@ -19,7 +19,7 @@
/** /**
* @group conduit * @group conduit
*/ */
class ConduitAPIResponse { final class ConduitAPIResponse {
private $result; private $result;
private $errorCode; private $errorCode;

4
src/applications/conduit/storage/connectionlog/PhabricatorConduitConnectionLog.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/** /**
* @group conduit * @group conduit
*/ */
class PhabricatorConduitConnectionLog extends PhabricatorConduitDAO { final class PhabricatorConduitConnectionLog extends PhabricatorConduitDAO {
protected $client; protected $client;
protected $clientVersion; protected $clientVersion;

4
src/applications/conduit/storage/token/PhabricatorConduitCertificateToken.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/** /**
* @group conduit * @group conduit
*/ */
class PhabricatorConduitCertificateToken extends PhabricatorConduitDAO { final class PhabricatorConduitCertificateToken extends PhabricatorConduitDAO {
protected $userPHID; protected $userPHID;
protected $token; protected $token;

4
src/applications/countdown/storage/timer/PhabricatorTimer.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class PhabricatorTimer extends PhabricatorCountdownDAO { final class PhabricatorTimer extends PhabricatorCountdownDAO {
protected $id; protected $id;
protected $title; protected $title;

2
src/applications/differential/data/revisionlist/DifferentialRevisionListData.php
View file

@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class DifferentialRevisionListData { final class DifferentialRevisionListData {
const QUERY_OPEN_OWNED = 'open'; const QUERY_OPEN_OWNED = 'open';
const QUERY_OPEN_REVIEWER = 'reviewer'; const QUERY_OPEN_REVIEWER = 'reviewer';

2
src/applications/differential/editor/comment/DifferentialCommentEditor.php
View file

@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class DifferentialCommentEditor { final class DifferentialCommentEditor {
protected $revision; protected $revision;
protected $actorPHID; protected $actorPHID;

2
src/applications/differential/editor/revision/DifferentialRevisionEditor.php
View file

@ -21,7 +21,7 @@
* reviewers, diffs, and CCs. Unlike simple edits, these changes trigger * reviewers, diffs, and CCs. Unlike simple edits, these changes trigger
* complicated email workflows. * complicated email workflows.
*/ */
class DifferentialRevisionEditor { final class DifferentialRevisionEditor {
protected $revision; protected $revision;
protected $actorPHID; protected $actorPHID;

4
src/applications/differential/field/exception/validation/DifferentialFieldValidationException.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -16,6 +16,6 @@
* limitations under the License. * limitations under the License.
*/ */
class DifferentialFieldValidationException extends Exception { final class DifferentialFieldValidationException extends Exception {
} }

4
src/applications/differential/mail/ccwelcome/DifferentialCCWelcomeMail.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class DifferentialCCWelcomeMail extends DifferentialReviewRequestMail { final class DifferentialCCWelcomeMail extends DifferentialReviewRequestMail {
protected function renderSubject() { protected function renderSubject() {
$revision = $this->getRevision(); $revision = $this->getRevision();

2
src/applications/differential/mail/comment/DifferentialCommentMail.php
View file

@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class DifferentialCommentMail extends DifferentialMail { final class DifferentialCommentMail extends DifferentialMail {
protected $changedByCommit; protected $changedByCommit;

4
src/applications/differential/mail/diffcontent/DifferentialDiffContentMail.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class DifferentialDiffContentMail extends DifferentialMail { final class DifferentialDiffContentMail extends DifferentialMail {
protected $content; protected $content;

4
src/applications/differential/mail/exception/DifferentialExceptionMail.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class DifferentialExceptionMail extends DifferentialMail { final class DifferentialExceptionMail extends DifferentialMail {
public function __construct( public function __construct(
DifferentialRevision $revision, DifferentialRevision $revision,

4
src/applications/differential/mail/newdiff/DifferentialNewDiffMail.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class DifferentialNewDiffMail extends DifferentialReviewRequestMail { final class DifferentialNewDiffMail extends DifferentialReviewRequestMail {
protected function renderSubject() { protected function renderSubject() {
$revision = $this->getRevision(); $revision = $this->getRevision();

2
src/applications/differential/parser/changeset/DifferentialChangesetParser.php
View file

@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class DifferentialChangesetParser { final class DifferentialChangesetParser {
protected $visible = array(); protected $visible = array();
protected $new = array(); protected $new = array();

2
src/applications/differential/replyhandler/DifferentialReplyHandler.php
View file

@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class DifferentialReplyHandler extends PhabricatorMailReplyHandler { final class DifferentialReplyHandler extends PhabricatorMailReplyHandler {
private $receivedMail; private $receivedMail;

2
src/applications/differential/storage/changeset/DifferentialChangeset.php
View file

@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class DifferentialChangeset extends DifferentialDAO { final class DifferentialChangeset extends DifferentialDAO {
protected $diffID; protected $diffID;
protected $oldFile; protected $oldFile;

2
src/applications/differential/storage/comment/DifferentialComment.php
View file

@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class DifferentialComment extends DifferentialDAO { final class DifferentialComment extends DifferentialDAO {
const METADATA_ADDED_REVIEWERS = 'added-reviewers'; const METADATA_ADDED_REVIEWERS = 'added-reviewers';
const METADATA_ADDED_CCS = 'added-ccs'; const METADATA_ADDED_CCS = 'added-ccs';

2
src/applications/differential/storage/diff/DifferentialDiff.php
View file

@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class DifferentialDiff extends DifferentialDAO { final class DifferentialDiff extends DifferentialDAO {
protected $revisionID; protected $revisionID;
protected $authorPHID; protected $authorPHID;

4
src/applications/differential/storage/diffproperty/DifferentialDiffProperty.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class DifferentialDiffProperty extends DifferentialDAO { final class DifferentialDiffProperty extends DifferentialDAO {
protected $diffID; protected $diffID;
protected $name; protected $name;

4
src/applications/differential/storage/hunk/DifferentialHunk.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class DifferentialHunk extends DifferentialDAO { final class DifferentialHunk extends DifferentialDAO {
protected $changesetID; protected $changesetID;
protected $changes; protected $changes;

2
src/applications/differential/storage/inlinecomment/DifferentialInlineComment.php
View file

@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class DifferentialInlineComment extends DifferentialDAO { final class DifferentialInlineComment extends DifferentialDAO {
protected $revisionID; protected $revisionID;
protected $commentID; protected $commentID;

2
src/applications/differential/storage/revision/DifferentialRevision.php
View file

@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class DifferentialRevision extends DifferentialDAO { final class DifferentialRevision extends DifferentialDAO {
protected $title; protected $title;
protected $status; protected $status;

2
src/applications/differential/view/changesetdetailview/DifferentialChangesetDetailView.php
View file

@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class DifferentialChangesetDetailView extends AphrontView { final class DifferentialChangesetDetailView extends AphrontView {
private $changeset; private $changeset;
private $buttons = array(); private $buttons = array();

2
src/applications/differential/view/changesetlistview/DifferentialChangesetListView.php
View file

@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class DifferentialChangesetListView extends AphrontView { final class DifferentialChangesetListView extends AphrontView {
private $changesets = array(); private $changesets = array();
private $references = array(); private $references = array();

4
src/applications/diffusion/query/pathchange/base/DiffusionPathChangeQuery.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class DiffusionPathChangeQuery { final class DiffusionPathChangeQuery {
private $request; private $request;

6
src/applications/diffusion/request/base/DiffusionRequest.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -16,6 +16,10 @@
* limitations under the License. * limitations under the License.
*/ */
/**
* TODO: This might need to be concrete-extensible, but straighten out the
* class hierarchy here.
*/
class DiffusionRequest { class DiffusionRequest {
protected $callsign; protected $callsign;

4
src/applications/diffusion/request/git/DiffusionGitRequest.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class DiffusionGitRequest extends DiffusionRequest { final class DiffusionGitRequest extends DiffusionRequest {
protected function initializeFromAphrontRequestDictionary(array $data) { protected function initializeFromAphrontRequestDictionary(array $data) {
parent::initializeFromAphrontRequestDictionary($data); parent::initializeFromAphrontRequestDictionary($data);

4
src/applications/diffusion/request/mercurial/DiffusionMercurialRequest.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -18,7 +18,7 @@
// TODO: This has some minor code duplication vs the Git request that could be // TODO: This has some minor code duplication vs the Git request that could be
// shared. // shared.
class DiffusionMercurialRequest extends DiffusionRequest { final class DiffusionMercurialRequest extends DiffusionRequest {
protected function initializeFromAphrontRequestDictionary(array $data) { protected function initializeFromAphrontRequestDictionary(array $data) {
parent::initializeFromAphrontRequestDictionary($data); parent::initializeFromAphrontRequestDictionary($data);

4
src/applications/diffusion/request/svn/DiffusionSvnRequest.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class DiffusionSvnRequest extends DiffusionRequest { final class DiffusionSvnRequest extends DiffusionRequest {
protected function initializeFromAphrontRequestDictionary(array $data) { protected function initializeFromAphrontRequestDictionary(array $data) {
parent::initializeFromAphrontRequestDictionary($data); parent::initializeFromAphrontRequestDictionary($data);

Some files were not shown because too many files have changed in this diff Show more