Remove "getApplicationTransactionObject()" from ApplicationTransactionInterface

Summary:
Depends on D19919. Ref T11351. This method appeared in D8802 (note that "get...Object" was renamed to "get...Transaction" there, so this method was actually "new" even though a method of the same name had existed before).

The goal at the time was to let Harbormaster post build results to Diffs and have them end up on Revisions, but this eventually got a better implementation (see below) where the Harbormaster-specific code can just specify a "publishable object" where build results should go.

The new `get...Object` semantics ultimately broke some stuff, and the actual implementation in Differential was removed in D10911, so this method hasn't really served a purpose since December 2014. I think that broke the Harbormaster thing by accident and we just lived with it for a bit, then Harbormaster got some more work and D17139 introduced "publishable" objects which was a better approach. This was later refined by D19281.

So: the original problem (sending build results to the right place) has a good solution now, this method hasn't done anything for 4 years, and it was probably a bad idea in the first place since it's pretty weird/surprising/fragile.

Note that `Comment` objects still have an unrelated method with the same name. In that case, the method ties the `Comment` storage object to the related `Transaction` storage object.

Test Plan: Grepped for `getApplicationTransactionObject`, verified that all remaining callsites are related to `Comment` objects.

Reviewers: amckinley

Reviewed By: amckinley

Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam

Maniphest Tasks: T11351

Differential Revision: https://secure.phabricator.com/D19920

src/applications/almanac/storage/AlmanacBinding.php

@@ -206,10 +206,6 @@ final class AlmanacBinding
     return new AlmanacBindingEditor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new AlmanacBindingTransaction();
   }

src/applications/almanac/storage/AlmanacDevice.php

@@ -204,10 +204,6 @@ final class AlmanacDevice
     return new AlmanacDeviceEditor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new AlmanacDeviceTransaction();
   }

src/applications/almanac/storage/AlmanacInterface.php

@@ -168,10 +168,6 @@ final class AlmanacInterface
     return new AlmanacInterfaceEditor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new AlmanacInterfaceTransaction();
   }

src/applications/almanac/storage/AlmanacNamespace.php

@@ -191,10 +191,6 @@ final class AlmanacNamespace
     return new AlmanacNamespaceEditor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new AlmanacNamespaceTransaction();
   }

src/applications/almanac/storage/AlmanacNetwork.php

@@ -61,10 +61,6 @@ final class AlmanacNetwork
     return new AlmanacNetworkEditor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new AlmanacNetworkTransaction();
   }

src/applications/almanac/storage/AlmanacService.php

@@ -226,10 +226,6 @@ final class AlmanacService
     return new AlmanacServiceEditor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new AlmanacServiceTransaction();
   }

src/applications/auth/storage/PhabricatorAuthPassword.php

@@ -217,10 +217,6 @@ final class PhabricatorAuthPassword
     return new PhabricatorAuthPasswordEditor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new PhabricatorAuthPasswordTransaction();
   }

src/applications/auth/storage/PhabricatorAuthProviderConfig.php

@@ -91,10 +91,6 @@ final class PhabricatorAuthProviderConfig
     return new PhabricatorAuthProviderConfigEditor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new PhabricatorAuthProviderConfigTransaction();
   }

src/applications/auth/storage/PhabricatorAuthSSHKey.php

@@ -159,10 +159,6 @@ final class PhabricatorAuthSSHKey
     return new PhabricatorAuthSSHKeyEditor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new PhabricatorAuthSSHKeyTransaction();
   }

src/applications/badges/storage/PhabricatorBadgesBadge.php

@@ -125,10 +125,6 @@ final class PhabricatorBadgesBadge extends PhabricatorBadgesDAO
     return new PhabricatorBadgesEditor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new PhabricatorBadgesTransaction();
   }

src/applications/base/PhabricatorApplication.php

@@ -649,10 +649,6 @@ abstract class PhabricatorApplication
     return new PhabricatorApplicationEditor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new PhabricatorApplicationApplicationTransaction();
   }

src/applications/calendar/storage/PhabricatorCalendarEvent.php

@@ -1311,10 +1311,6 @@ final class PhabricatorCalendarEvent extends PhabricatorCalendarDAO
     return new PhabricatorCalendarEventEditor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new PhabricatorCalendarEventTransaction();
   }

src/applications/calendar/storage/PhabricatorCalendarExport.php

@@ -166,10 +166,6 @@ final class PhabricatorCalendarExport extends PhabricatorCalendarDAO
     return new PhabricatorCalendarExportEditor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new PhabricatorCalendarExportTransaction();
   }

src/applications/calendar/storage/PhabricatorCalendarImport.php

@@ -140,10 +140,6 @@ final class PhabricatorCalendarImport
     return new PhabricatorCalendarImportEditor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new PhabricatorCalendarImportTransaction();
   }

src/applications/config/storage/PhabricatorConfigEntry.php

@@ -61,10 +61,6 @@ final class PhabricatorConfigEntry
     return new PhabricatorConfigEditor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new PhabricatorConfigTransaction();
   }

src/applications/conpherence/storage/ConpherenceThread.php

@@ -311,10 +311,6 @@ final class ConpherenceThread extends ConpherenceDAO
     return new ConpherenceEditor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new ConpherenceTransaction();
   }

src/applications/countdown/storage/PhabricatorCountdown.php

@@ -95,10 +95,6 @@ final class PhabricatorCountdown extends PhabricatorCountdownDAO
     return new PhabricatorCountdownEditor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new PhabricatorCountdownTransaction();
   }

src/applications/dashboard/storage/PhabricatorDashboard.php

@@ -130,10 +130,6 @@ final class PhabricatorDashboard extends PhabricatorDashboardDAO
     return new PhabricatorDashboardTransactionEditor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new PhabricatorDashboardTransaction();
   }

src/applications/dashboard/storage/PhabricatorDashboardPanel.php

@@ -113,10 +113,6 @@ final class PhabricatorDashboardPanel
     return new PhabricatorDashboardPanelTransactionEditor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new PhabricatorDashboardPanelTransaction();
   }

src/applications/differential/storage/DifferentialDiff.php

@@ -699,10 +699,6 @@ final class DifferentialDiff
     return new DifferentialDiffEditor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new DifferentialDiffTransaction();
   }

src/applications/differential/storage/DifferentialRevision.php

@@ -991,10 +991,6 @@ final class DifferentialRevision extends DifferentialDAO
     return new DifferentialTransactionEditor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new DifferentialTransaction();
   }

src/applications/diviner/storage/DivinerLiveBook.php

@@ -143,10 +143,6 @@ final class DivinerLiveBook extends DivinerDAO
     return new DivinerLiveBookEditor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new DivinerLiveBookTransaction();
   }

src/applications/drydock/storage/DrydockBlueprint.php

@@ -295,10 +295,6 @@ final class DrydockBlueprint extends DrydockDAO
     return new DrydockBlueprintEditor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new DrydockBlueprintTransaction();
   }

src/applications/files/storage/PhabricatorFile.php

@@ -1544,10 +1544,6 @@ final class PhabricatorFile extends PhabricatorFileDAO
     return new PhabricatorFileEditor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new PhabricatorFileTransaction();
   }

src/applications/fund/storage/FundBacker.php

@@ -110,10 +110,6 @@ final class FundBacker extends FundDAO
     return new FundBackerEditor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new FundBackerTransaction();
   }

src/applications/fund/storage/FundInitiative.php

@@ -160,10 +160,6 @@ final class FundInitiative extends FundDAO
     return new FundInitiativeEditor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new FundInitiativeTransaction();
   }

src/applications/harbormaster/engine/HarbormasterBuildableEngine.php

@@ -96,9 +96,7 @@ abstract class HarbormasterBuildableEngine
     $publishable = $this->getPublishableObject();
     $editor = $this->newEditor();
 
-    $editor->applyTransactions(
-      $publishable->getApplicationTransactionObject(),
-      $xactions);
+    $editor->applyTransactions($publishable, $xactions);
   }
 
   public function getAuthorIdentity() {

src/applications/harbormaster/storage/HarbormasterBuildable.php

@@ -283,10 +283,6 @@ final class HarbormasterBuildable
     return new HarbormasterBuildableTransactionEditor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new HarbormasterBuildableTransaction();
   }

src/applications/harbormaster/storage/build/HarbormasterBuild.php

@@ -393,10 +393,6 @@ final class HarbormasterBuild extends HarbormasterDAO
     return new HarbormasterBuildTransactionEditor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new HarbormasterBuildTransaction();
   }

src/applications/harbormaster/storage/configuration/HarbormasterBuildPlan.php

@@ -136,10 +136,6 @@ final class HarbormasterBuildPlan extends HarbormasterDAO
     return new HarbormasterBuildPlanEditor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new HarbormasterBuildPlanTransaction();
   }

src/applications/harbormaster/storage/configuration/HarbormasterBuildStep.php

@@ -121,10 +121,6 @@ final class HarbormasterBuildStep extends HarbormasterDAO
     return new HarbormasterBuildStepEditor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new HarbormasterBuildStepTransaction();
   }

src/applications/herald/storage/HeraldRule.php

@@ -318,10 +318,6 @@ final class HeraldRule extends HeraldDAO
     return new HeraldRuleEditor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new HeraldRuleTransaction();
   }

src/applications/herald/storage/HeraldWebhook.php

@@ -200,10 +200,6 @@ final class HeraldWebhook
     return new HeraldWebhookEditor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new HeraldWebhookTransaction();
   }

src/applications/legalpad/storage/LegalpadDocument.php

@@ -209,10 +209,6 @@ final class LegalpadDocument extends LegalpadDAO
     return new LegalpadDocumentEditor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new LegalpadTransaction();
   }

src/applications/macro/storage/PhabricatorFileImageMacro.php

@@ -98,10 +98,6 @@ final class PhabricatorFileImageMacro extends PhabricatorFileDAO
     return new PhabricatorMacroEditor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new PhabricatorMacroTransaction();
   }

src/applications/maniphest/storage/ManiphestTask.php

@@ -452,10 +452,6 @@ final class ManiphestTask extends ManiphestDAO
     return new ManiphestTransactionEditor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new ManiphestTransaction();
   }

src/applications/metamta/storage/PhabricatorMetaMTAApplicationEmail.php

@@ -123,10 +123,6 @@ final class PhabricatorMetaMTAApplicationEmail
     return new PhabricatorMetaMTAApplicationEmailEditor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new PhabricatorMetaMTAApplicationEmailTransaction();
   }

src/applications/nuance/storage/NuanceItem.php

@@ -193,10 +193,6 @@ final class NuanceItem
     return new NuanceItemEditor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new NuanceItemTransaction();
   }

src/applications/nuance/storage/NuanceQueue.php

@@ -79,10 +79,6 @@ final class NuanceQueue
     return new NuanceQueueEditor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new NuanceQueueTransaction();
   }

src/applications/nuance/storage/NuanceSource.php

@@ -99,10 +99,6 @@ final class NuanceSource extends NuanceDAO
     return new NuanceSourceEditor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new NuanceSourceTransaction();
   }

src/applications/oauthserver/storage/PhabricatorOAuthServerClient.php

@@ -91,10 +91,6 @@ final class PhabricatorOAuthServerClient
     return new PhabricatorOAuthServerEditor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new PhabricatorOAuthServerTransaction();
   }

src/applications/owners/storage/PhabricatorOwnersPackage.php

@@ -607,10 +607,6 @@ final class PhabricatorOwnersPackage
     return new PhabricatorOwnersPackageTransactionEditor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new PhabricatorOwnersPackageTransaction();
   }

src/applications/packages/storage/PhabricatorPackagesPackage.php

@@ -189,10 +189,6 @@ final class PhabricatorPackagesPackage
     return new PhabricatorPackagesPackageEditor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new PhabricatorPackagesPackageTransaction();
   }

src/applications/packages/storage/PhabricatorPackagesPublisher.php

@@ -165,10 +165,6 @@ final class PhabricatorPackagesPublisher
     return new PhabricatorPackagesPublisherEditor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new PhabricatorPackagesPublisherTransaction();
   }

src/applications/packages/storage/PhabricatorPackagesVersion.php

@@ -156,10 +156,6 @@ final class PhabricatorPackagesVersion
     return new PhabricatorPackagesVersionEditor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new PhabricatorPackagesVersionTransaction();
   }

src/applications/passphrase/storage/PassphraseCredential.php

@@ -117,10 +117,6 @@ final class PassphraseCredential extends PassphraseDAO
     return new PassphraseCredentialTransactionEditor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new PassphraseCredentialTransaction();
   }

src/applications/paste/storage/PhabricatorPaste.php

@@ -219,10 +219,6 @@ final class PhabricatorPaste extends PhabricatorPasteDAO
     return new PhabricatorPasteEditor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new PhabricatorPasteTransaction();
   }

src/applications/people/storage/PhabricatorUser.php

@@ -1371,10 +1371,6 @@ final class PhabricatorUser
     return new PhabricatorUserTransactionEditor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new PhabricatorUserTransaction();
   }

src/applications/phame/storage/PhameBlog.php

@@ -331,10 +331,6 @@ final class PhameBlog extends PhameDAO
     return new PhameBlogEditor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new PhameBlogTransaction();
   }

src/applications/phame/storage/PhamePost.php

@@ -279,10 +279,6 @@ final class PhamePost extends PhameDAO
     return new PhamePostEditor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new PhamePostTransaction();
   }

src/applications/phlux/storage/PhluxVariable.php

@@ -41,10 +41,6 @@ final class PhluxVariable extends PhluxDAO
     return new PhluxVariableEditor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new PhluxTransaction();
   }

src/applications/pholio/storage/PholioMock.php

@@ -221,10 +221,6 @@ final class PholioMock extends PholioDAO
     return new PholioMockEditor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new PholioTransaction();
   }

src/applications/phortune/storage/PhortuneAccount.php

@@ -105,10 +105,6 @@ final class PhortuneAccount extends PhortuneDAO
     return new PhortuneAccountEditor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new PhortuneAccountTransaction();
   }

src/applications/phortune/storage/PhortuneCart.php

@@ -636,10 +636,6 @@ final class PhortuneCart extends PhortuneDAO
     return new PhortuneCartEditor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new PhortuneCartTransaction();
   }

src/applications/phortune/storage/PhortuneMerchant.php

@@ -78,10 +78,6 @@ final class PhortuneMerchant extends PhortuneDAO
     return new PhortuneMerchantEditor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new PhortuneMerchantTransaction();
   }

src/applications/phortune/storage/PhortunePaymentProviderConfig.php

@@ -106,10 +106,6 @@ final class PhortunePaymentProviderConfig extends PhortuneDAO
     return new PhortunePaymentProviderConfigEditor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new PhortunePaymentProviderConfigTransaction();
   }

src/applications/phriction/storage/PhrictionDocument.php

@@ -223,10 +223,6 @@ final class PhrictionDocument extends PhrictionDAO
     return new PhrictionTransactionEditor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new PhrictionTransaction();
   }

src/applications/phurl/storage/PhabricatorPhurlURL.php

@@ -157,10 +157,6 @@ final class PhabricatorPhurlURL extends PhabricatorPhurlDAO
     return new PhabricatorPhurlURLEditor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new PhabricatorPhurlURLTransaction();
   }

src/applications/ponder/storage/PonderAnswer.php

@@ -117,10 +117,6 @@ final class PonderAnswer extends PonderDAO
     return new PonderAnswerEditor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new PonderAnswerTransaction();
   }

src/applications/ponder/storage/PonderQuestion.php

@@ -145,10 +145,6 @@ final class PonderQuestion extends PonderDAO
     return new PonderQuestionEditor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new PonderQuestionTransaction();
   }

src/applications/project/storage/PhabricatorProject.php

@@ -695,10 +695,6 @@ final class PhabricatorProject extends PhabricatorProjectDAO
     return new PhabricatorProjectTransactionEditor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new PhabricatorProjectTransaction();
   }

src/applications/project/storage/PhabricatorProjectColumn.php

@@ -234,10 +234,6 @@ final class PhabricatorProjectColumn
     return new PhabricatorProjectColumnTransactionEditor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new PhabricatorProjectColumnTransaction();
   }

src/applications/releeph/storage/ReleephBranch.php

@@ -158,10 +158,6 @@ final class ReleephBranch extends ReleephDAO
     return new ReleephBranchEditor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new ReleephBranchTransaction();
   }

src/applications/releeph/storage/ReleephProject.php

@@ -119,10 +119,6 @@ final class ReleephProject extends ReleephDAO
     return new ReleephProductEditor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new ReleephProductTransaction();
   }

src/applications/releeph/storage/ReleephRequest.php

@@ -299,10 +299,6 @@ final class ReleephRequest extends ReleephDAO
     return new ReleephRequestTransactionalEditor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new ReleephRequestTransaction();
   }

src/applications/repository/storage/PhabricatorRepository.php

@@ -2613,10 +2613,6 @@ final class PhabricatorRepository extends PhabricatorRepositoryDAO
     return new PhabricatorRepositoryEditor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new PhabricatorRepositoryTransaction();
   }

src/applications/repository/storage/PhabricatorRepositoryCommit.php

@@ -731,10 +731,6 @@ final class PhabricatorRepositoryCommit
     return new PhabricatorAuditEditor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new PhabricatorAuditTransaction();
   }

src/applications/repository/storage/PhabricatorRepositoryIdentity.php

@@ -134,10 +134,6 @@ final class PhabricatorRepositoryIdentity
     return new DiffusionRepositoryIdentityEditor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new PhabricatorRepositoryIdentityTransaction();
   }

src/applications/repository/storage/PhabricatorRepositoryURI.php

@@ -605,10 +605,6 @@ final class PhabricatorRepositoryURI
     return new DiffusionURIEditor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new PhabricatorRepositoryURITransaction();
   }

src/applications/search/storage/PhabricatorProfileMenuItemConfiguration.php

@@ -265,10 +265,6 @@ final class PhabricatorProfileMenuItemConfiguration
     return new PhabricatorProfileMenuEditor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new PhabricatorProfileMenuItemConfigurationTransaction();
   }

src/applications/settings/storage/PhabricatorUserPreferences.php

@@ -245,10 +245,6 @@ final class PhabricatorUserPreferences
     return new PhabricatorUserPreferencesEditor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new PhabricatorUserPreferencesTransaction();
   }

src/applications/slowvote/storage/PhabricatorSlowvotePoll.php

@@ -131,10 +131,6 @@ final class PhabricatorSlowvotePoll extends PhabricatorSlowvoteDAO
     return new PhabricatorSlowvoteEditor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new PhabricatorSlowvoteTransaction();
   }

src/applications/spaces/storage/PhabricatorSpacesNamespace.php

@@ -91,10 +91,6 @@ final class PhabricatorSpacesNamespace
     return new PhabricatorSpacesNamespaceEditor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new PhabricatorSpacesNamespaceTransaction();
   }

src/applications/subscriptions/controller/PhabricatorSubscriptionsEditController.php

@@ -77,9 +77,7 @@ final class PhabricatorSubscriptionsEditController
         ->setContinueOnMissingFields(true)
         ->setContentSourceFromRequest($request);
 
-      $editor->applyTransactions(
-        $object->getApplicationTransactionObject(),
-        array($xaction));
+      $editor->applyTransactions($object, array($xaction));
     } else {
 
       // TODO: Eventually, get rid of this once everything implements

src/applications/subscriptions/controller/PhabricatorSubscriptionsMuteController.php

@@ -55,9 +55,7 @@ final class PhabricatorSubscriptionsMuteController
         ->setContinueOnMissingFields(true)
         ->setContentSourceFromRequest($request);
 
-      $editor->applyTransactions(
-        $object->getApplicationTransactionObject(),
-        array($xaction));
+      $editor->applyTransactions($object, array($xaction));
 
       return id(new AphrontReloadResponse())->setURI($object_uri);
     }

src/applications/tokens/editor/PhabricatorTokenGivenEditor.php

@@ -166,9 +166,7 @@ final class PhabricatorTokenGivenEditor
       ->setContinueOnNoEffect(true)
       ->setContinueOnMissingFields(true);
 
-    $editor->applyTransactions(
-      $object->getApplicationTransactionObject(),
-      $xactions);
+    $editor->applyTransactions($object, $xactions);
   }
 
 }

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

@@ -3766,7 +3766,6 @@ abstract class PhabricatorApplicationTransactionEditor
 
       $editor = $node->getApplicationTransactionEditor();
       $template = $node->getApplicationTransactionTemplate();
-      $target = $node->getApplicationTransactionObject();
 
       if (isset($add[$node->getPHID()])) {
         $edge_edit_type = '+';
@@ -3792,7 +3791,7 @@ abstract class PhabricatorApplicationTransactionEditor
         ->setActingAsPHID($this->getActingAsPHID())
         ->setContentSource($this->getContentSource());
 
-      $editor->applyTransactions($target, array($template));
+      $editor->applyTransactions($node, array($template));
     }
   }
 

src/applications/transactions/interface/PhabricatorApplicationTransactionInterface.php

@@ -17,17 +17,6 @@ interface PhabricatorApplicationTransactionInterface {
   public function getApplicationTransactionEditor();
 
 
-  /**
-   * Return the object to apply transactions to. Normally this is the current
-   * object (that is, `$this`), but in some cases transactions may apply to
-   * a different object: for example, @{class:DifferentialDiff} applies
-   * transactions to the associated @{class:DifferentialRevision}.
-   *
-   * @return PhabricatorLiskDAO Object to apply transactions to.
-   */
-  public function getApplicationTransactionObject();
-
-
   /**
    * Return a template transaction for this object.
    *
@@ -47,10 +36,6 @@ interface PhabricatorApplicationTransactionInterface {
     return new <<<???>>>Editor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new <<<???>>>Transaction();
   }

src/applications/transactions/replyhandler/PhabricatorApplicationTransactionReplyHandler.php

@@ -107,11 +107,9 @@ abstract class PhabricatorApplicationTransactionReplyHandler
         ->attachComment($comment);
     }
 
-    $target = $object->getApplicationTransactionObject();
-
     $this->newEditor($mail)
       ->setContinueOnNoEffect(true)
-      ->applyTransactions($target, $xactions);
+      ->applyTransactions($object, $xactions);
   }
 
   private function processMailCommands(

src/applications/transactions/storage/PhabricatorEditEngineConfiguration.php

@@ -339,10 +339,6 @@ final class PhabricatorEditEngineConfiguration
     return new PhabricatorEditEngineConfigurationEditor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new PhabricatorEditEngineConfigurationTransaction();
   }

src/infrastructure/daemon/workers/storage/PhabricatorWorkerBulkJob.php

@@ -233,10 +233,6 @@ final class PhabricatorWorkerBulkJob
     return new PhabricatorWorkerBulkJobEditor();
   }
 
-  public function getApplicationTransactionObject() {
-    return $this;
-  }
-
   public function getApplicationTransactionTemplate() {
     return new PhabricatorWorkerBulkJobTransaction();
   }