revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-19 05:12:41 +01:00
Code Issues Releases Wiki Activity

Remove "PHID Manager" Tool list interface

Browse source 
Summary: This was well-intentioned but has not actually proven to be useful.

Test Plan:
  - No list tab shows up anymore.
  - Looked up a PHID.

Reviewers: btrahan, jungejason, Girish

Reviewed By: Girish

CC: aran, jungejason, edward, emiraga, Girish, nh, tuomaspelkonen, epriestley

Maniphest Tasks: T631

Differential Revision: 1234
This commit is contained in:
epriestley 2011-12-17 16:10:44 -08:00
parent ee620bde6d
commit 125e5b16db
5 changed files with 0 additions and 92 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/aphront/default/configuration/AphrontDefaultApplicationConfiguration.php
View file

@ -70,7 +70,6 @@ class AphrontDefaultApplicationConfiguration
),
'/phid/' => array(
'$' => 'PhabricatorPHIDLookupController',
'list/$' => 'PhabricatorPHIDListController',
),
'/people/' => array(
'$' => 'PhabricatorPeopleListController',

12
src/applications/phid/controller/base/PhabricatorPHIDController.php
View file

@ -24,18 +24,6 @@ abstract class PhabricatorPHIDController extends PhabricatorController {
$page->setApplicationName('PHID');
$page->setBaseURI('/phid/');
$page->setTitle(idx($data, 'title'));
$page->setTabs(
array(
'lookup' => array(
'href' => '/phid/',
'name' => 'PHID Lookup',
),
'phids' => array(
'href' => '/phid/list/',
'name' => 'PHID List',
),
),
idx($data, 'tab'));
$page->setGlyph('#');
$page->appendChild($view);

60
src/applications/phid/controller/list/PhabricatorPHIDListController.php
View file

@ -1,60 +0,0 @@
<?php
/*
* Copyright 2011 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
class PhabricatorPHIDListController
extends PhabricatorPHIDController {
public function processRequest() {
$items = id(new PhabricatorPHID())->loadAllWhere(
'1 = 1 ORDER BY id DESC limit 100');
$rows = array();
foreach ($items as $item) {
$rows[] = array(
phutil_escape_html($item->getPHID()),
phutil_escape_html($item->getPHIDType()),
phutil_escape_html($item->getOwnerPHID()),
phutil_escape_html($item->getParentPHID()),
);
}
$table = new AphrontTableView($rows);
$table->setHeaders(
array(
'PHID',
'Type',
'Owner PHID',
'Parent PHID',
));
$panel = new AphrontPanelView();
$panel->appendChild($table);
$panel->setHeader('PHIDs');
$panel->setCreateButton('Allocate New PHID', '/phid/new/');
return $this->buildStandardPageResponse(
array(
$panel,
),
array(
'title' => 'PHIDs',
'tab' => 'phids',
));
}
}

18
src/applications/phid/controller/list/__init__.php
View file

@ -1,18 +0,0 @@
<?php
/**
* This file is automatically generated. Lint this module to rebuild it.
* @generated
*/
phutil_require_module('phabricator', 'applications/phid/controller/base');
phutil_require_module('phabricator', 'applications/phid/storage/phid');
phutil_require_module('phabricator', 'view/control/table');
phutil_require_module('phabricator', 'view/layout/panel');
phutil_require_module('phutil', 'markup');
phutil_require_module('phutil', 'utils');
phutil_require_source('PhabricatorPHIDListController.php');

1
src/applications/phid/controller/lookup/PhabricatorPHIDLookupController.php
View file

@ -105,7 +105,6 @@ class PhabricatorPHIDLookupController
),
array(
'title' => 'PHID Lookup',
'tab' => 'lookup',
));
}