1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-10 08:52:39 +01:00

Remove timeline from Profile Manage

Summary: Not sure this page is really providing any value, the timeline always says "edited this object" and there is a list of actions. Seems we could move actions back to the profile proper, but they feel very... engineery to me. Or we could fix the timeline stories, but my guess is they aren't useful or we would have gotten such feedback.

Test Plan: Review manage page, timeline is gone. Page is clean.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D17230
This commit is contained in:
Chad Little 2017-01-19 12:51:54 -08:00
parent f8cebdc418
commit 1bcc8a3d98

View file

@ -45,11 +45,6 @@ final class PhabricatorPeopleProfileManageController
$nav = $this->getProfileMenu(); $nav = $this->getProfileMenu();
$nav->selectFilter(PhabricatorPeopleProfileMenuEngine::ITEM_MANAGE); $nav->selectFilter(PhabricatorPeopleProfileMenuEngine::ITEM_MANAGE);
$timeline = $this->buildTransactionTimeline(
$user,
new PhabricatorPeopleTransactionQuery());
$timeline->setShouldTerminate(true);
$crumbs = $this->buildApplicationCrumbs(); $crumbs = $this->buildApplicationCrumbs();
$crumbs->addTextCrumb(pht('Manage')); $crumbs->addTextCrumb(pht('Manage'));
$crumbs->setBorder(true); $crumbs->setBorder(true);
@ -57,11 +52,7 @@ final class PhabricatorPeopleProfileManageController
$manage = id(new PHUITwoColumnView()) $manage = id(new PHUITwoColumnView())
->setHeader($header) ->setHeader($header)
->setCurtain($curtain) ->setCurtain($curtain)
->addPropertySection(pht('Details'), $properties) ->addPropertySection(pht('Details'), $properties);
->setMainColumn(
array(
$timeline,
));
return $this->newPage() return $this->newPage()
->setTitle( ->setTitle(