1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-24 14:30:56 +01:00

Fixed replies to go on the correct side of the diff in Differential.

Summary:
Replies to comments went always to the left side of the diff. There
was a confusion between 'is_new' and 'on_right'. Database wants the
information if the reply is on the left or on the right. The database
does not care if the comment is a reply or an original comment.

The code looks a bit confusing, because the database field is called
'isNewFile' and that is used to determine, which side the comment
applies to.

Test Plan:
Tested that every of combination of new comment/reply to the left/right side
worked when editing and after submitting the comment.

Reviewed By: jungejason
Reviewers: jungejason
CC: epriestley, jungejason
Differential Revision: 148
This commit is contained in:
tuomaspelkonen 2011-04-18 16:10:18 -07:00
parent ecc32e4d08
commit 1c3e21dda1

View file

@ -122,7 +122,7 @@ class DifferentialInlineCommentEditController extends DifferentialController {
->setAuthorPHID($user->getPHID())
->setLineNumber($number)
->setLineLength($length)
->setIsNewFile($is_new)
->setIsNewFile($on_right)
->setContent($text)
->save();