mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-30 17:30:59 +01:00
No description
1c3e21dda1
Summary: Replies to comments went always to the left side of the diff. There was a confusion between 'is_new' and 'on_right'. Database wants the information if the reply is on the left or on the right. The database does not care if the comment is a reply or an original comment. The code looks a bit confusing, because the database field is called 'isNewFile' and that is used to determine, which side the comment applies to. Test Plan: Tested that every of combination of new comment/reply to the left/right side worked when editing and after submitting the comment. Reviewed By: jungejason Reviewers: jungejason CC: epriestley, jungejason Differential Revision: 148 |
||
|---|---|---|
| bin | ||
| conf | ||
| externals | ||
| resources | ||
| scripts | ||
| src | ||
| webroot | ||
| .arcconfig | ||
| .divinerconfig | ||
| .gitignore | ||
| README | ||
PROJECT STATUS: CAVEAT EMPTOR This is an unstable preview release. I'm open sourcing some of Facebook's internal tools, but they'll be unstable for probably at least a couple months. -epriestley WHAT IS PHABRICATOR? Phabricator is a suite of web applications that facilitate software development tasks, particularly code review. The primary application in the suite is Differential, a code review tool. Phabricator is highly unstable and has many missing features! These applications are being brought over from Facebook's internal toolset, but there's a lot of stuff that hasn't made it over yet. Feel free to follow the project but you probably shouldn't try to install this yet unless you're extremely ambitious or just want to take a look at it. I'm opening it up now mostly to make it easier for me to do test deployments outside of Facebook.