revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-10 08:52:39 +01:00
Code Issues Releases Wiki Activity

Fix comment previews in Quicksand

Browse source 
Summary:
Fixes T7063. Fixes T7059. We were running some extra unnecessary behaviors. In particular, we would render the menu but not actually send it over the wire, so some behaviors would execute, fail to find the nodes they expected, and throw. This cascaded into some other failures.

Do less work and don't activate behaviors which won't be able to run.

Test Plan: Clicked around, no more errors on page transition. Comment previews work.

Reviewers: btrahan, chad

Reviewed By: chad

Subscribers: epriestley

Maniphest Tasks: T7059, T7063

Differential Revision: https://secure.phabricator.com/D12188
This commit is contained in:
epriestley 2015-03-28 06:54:04 -07:00
parent 637974a190
commit 21454842bf
1 changed files with 1 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/view/page/PhabricatorStandardPageView.php
View file

@ -590,9 +590,7 @@ final class PhabricatorStandardPageView extends PhabricatorBarePageView {
} }
public function renderForQuicksand() { public function renderForQuicksand() {
// TODO: We could run a lighter version of this and skip some work. In parent::willRenderPage();
// particular, we end up including many redundant resources.
$this->willRenderPage();
$response = $this->renderPageBodyContent(); $response = $this->renderPageBodyContent();
$response = $this->willSendResponse($response); $response = $this->willSendResponse($response);