mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-23 22:10:55 +01:00
Fix comment previews in Quicksand
Summary: Fixes T7063. Fixes T7059. We were running some extra unnecessary behaviors. In particular, we would render the menu but not actually send it over the wire, so some behaviors would execute, fail to find the nodes they expected, and throw. This cascaded into some other failures. Do less work and don't activate behaviors which won't be able to run. Test Plan: Clicked around, no more errors on page transition. Comment previews work. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T7059, T7063 Differential Revision: https://secure.phabricator.com/D12188
This commit is contained in:
parent
637974a190
commit
21454842bf
1 changed files with 1 additions and 3 deletions
|
@ -590,9 +590,7 @@ final class PhabricatorStandardPageView extends PhabricatorBarePageView {
|
|||
}
|
||||
|
||||
public function renderForQuicksand() {
|
||||
// TODO: We could run a lighter version of this and skip some work. In
|
||||
// particular, we end up including many redundant resources.
|
||||
$this->willRenderPage();
|
||||
parent::willRenderPage();
|
||||
$response = $this->renderPageBodyContent();
|
||||
$response = $this->willSendResponse($response);
|
||||
|
||||
|
|
Loading…
Reference in a new issue