Simplify the implementation of PhabricatorPHIDType subclasses

Summary: Instead of implementing the `getTypeConstant` method in all subclasses of `PhabricatorPHIDType`, provide a `final` implementation in the base class which uses reflection. See D9837 for a similar implementation.

Test Plan: Ran `arc unit`.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: epriestley, Korvin, hach-que

Differential Revision: https://secure.phabricator.com/D9985

src/applications/auth/phid/PhabricatorAuthPHIDTypeAuthFactor.php

@@ -4,10 +4,6 @@ final class PhabricatorAuthPHIDTypeAuthFactor extends PhabricatorPHIDType {
 
   const TYPECONST = 'AFTR';
 
-  public function getTypeConstant() {
-    return self::TYPECONST;
-  }
-
   public function getTypeName() {
     return pht('Auth Factor');
   }

src/applications/calendar/phid/PhabricatorCalendarPHIDTypeEvent.php

@@ -4,10 +4,6 @@ final class PhabricatorCalendarPHIDTypeEvent extends PhabricatorPHIDType {
 
   const TYPECONST = 'CEVT';
 
-  public function getTypeConstant() {
-    return self::TYPECONST;
-  }
-
   public function getTypeName() {
     return pht('Event');
   }

src/applications/config/phid/PhabricatorConfigPHIDTypeConfig.php

@@ -4,10 +4,6 @@ final class PhabricatorConfigPHIDTypeConfig extends PhabricatorPHIDType {
 
   const TYPECONST = 'CONF';
 
-  public function getTypeConstant() {
-    return self::TYPECONST;
-  }
-
   public function getTypeName() {
     return pht('Config');
   }

src/applications/conpherence/phid/PhabricatorConpherencePHIDTypeThread.php

@@ -4,10 +4,6 @@ final class PhabricatorConpherencePHIDTypeThread extends PhabricatorPHIDType {
 
   const TYPECONST = 'CONP';
 
-  public function getTypeConstant() {
-    return self::TYPECONST;
-  }
-
   public function getTypeName() {
     return pht('Conpherence Thread');
   }

src/applications/countdown/phid/PhabricatorCountdownPHIDTypeCountdown.php

@@ -4,10 +4,6 @@ final class PhabricatorCountdownPHIDTypeCountdown extends PhabricatorPHIDType {
 
   const TYPECONST = 'CDWN';
 
-  public function getTypeConstant() {
-    return self::TYPECONST;
-  }
-
   public function getTypeName() {
     return pht('Countdown');
   }

src/applications/dashboard/phid/PhabricatorDashboardPHIDTypeDashboard.php

@@ -4,10 +4,6 @@ final class PhabricatorDashboardPHIDTypeDashboard extends PhabricatorPHIDType {
 
   const TYPECONST = 'DSHB';
 
-  public function getTypeConstant() {
-    return self::TYPECONST;
-  }
-
   public function getTypeName() {
     return pht('Dashboard');
   }

src/applications/dashboard/phid/PhabricatorDashboardPHIDTypePanel.php

@@ -4,10 +4,6 @@ final class PhabricatorDashboardPHIDTypePanel extends PhabricatorPHIDType {
 
   const TYPECONST = 'DSHP';
 
-  public function getTypeConstant() {
-    return self::TYPECONST;
-  }
-
   public function getTypeName() {
     return pht('Panel');
   }

src/applications/differential/phid/DifferentialPHIDTypeDiff.php

@@ -4,10 +4,6 @@ final class DifferentialPHIDTypeDiff extends PhabricatorPHIDType {
 
   const TYPECONST = 'DIFF';
 
-  public function getTypeConstant() {
-    return self::TYPECONST;
-  }
-
   public function getTypeName() {
     return pht('Differential Diff');
   }

src/applications/differential/phid/DifferentialPHIDTypeRevision.php

@@ -4,10 +4,6 @@ final class DifferentialPHIDTypeRevision extends PhabricatorPHIDType {
 
   const TYPECONST = 'DREV';
 
-  public function getTypeConstant() {
-    return self::TYPECONST;
-  }
-
   public function getTypeName() {
     return pht('Revision');
   }

src/applications/diviner/phid/DivinerPHIDTypeAtom.php

@@ -4,10 +4,6 @@ final class DivinerPHIDTypeAtom extends PhabricatorPHIDType {
 
   const TYPECONST = 'ATOM';
 
-  public function getTypeConstant() {
-    return self::TYPECONST;
-  }
-
   public function getTypeName() {
     return pht('Atom');
   }

src/applications/diviner/phid/DivinerPHIDTypeBook.php

@@ -4,10 +4,6 @@ final class DivinerPHIDTypeBook extends PhabricatorPHIDType {
 
   const TYPECONST = 'BOOK';
 
-  public function getTypeConstant() {
-    return self::TYPECONST;
-  }
-
   public function getTypeName() {
     return pht('Book');
   }

src/applications/drydock/phid/DrydockPHIDTypeBlueprint.php

@@ -4,10 +4,6 @@ final class DrydockPHIDTypeBlueprint extends PhabricatorPHIDType {
 
   const TYPECONST = 'DRYB';
 
-  public function getTypeConstant() {
-    return self::TYPECONST;
-  }
-
   public function getTypeName() {
     return pht('Blueprint');
   }

src/applications/drydock/phid/DrydockPHIDTypeLease.php

@@ -4,10 +4,6 @@ final class DrydockPHIDTypeLease extends PhabricatorPHIDType {
 
   const TYPECONST = 'DRYL';
 
-  public function getTypeConstant() {
-    return self::TYPECONST;
-  }
-
   public function getTypeName() {
     return pht('Drydock Lease');
   }

src/applications/drydock/phid/DrydockPHIDTypeResource.php

@@ -4,10 +4,6 @@ final class DrydockPHIDTypeResource extends PhabricatorPHIDType {
 
   const TYPECONST = 'DRYR';
 
-  public function getTypeConstant() {
-    return self::TYPECONST;
-  }
-
   public function getTypeName() {
     return pht('Drydock Resource');
   }

src/applications/files/phid/PhabricatorFilePHIDTypeFile.php

@@ -4,10 +4,6 @@ final class PhabricatorFilePHIDTypeFile extends PhabricatorPHIDType {
 
   const TYPECONST = 'FILE';
 
-  public function getTypeConstant() {
-    return self::TYPECONST;
-  }
-
   public function getTypeName() {
     return pht('File');
   }

src/applications/harbormaster/phid/HarbormasterPHIDTypeBuild.php

@@ -4,10 +4,6 @@ final class HarbormasterPHIDTypeBuild extends PhabricatorPHIDType {
 
   const TYPECONST = 'HMBD';
 
-  public function getTypeConstant() {
-    return self::TYPECONST;
-  }
-
   public function getTypeName() {
     return pht('Build');
   }

src/applications/harbormaster/phid/HarbormasterPHIDTypeBuildItem.php

@@ -4,10 +4,6 @@ final class HarbormasterPHIDTypeBuildItem extends PhabricatorPHIDType {
 
   const TYPECONST = 'HMBI';
 
-  public function getTypeConstant() {
-    return self::TYPECONST;
-  }
-
   public function getTypeName() {
     return pht('Build Item');
   }

src/applications/harbormaster/phid/HarbormasterPHIDTypeBuildLog.php

@@ -4,10 +4,6 @@ final class HarbormasterPHIDTypeBuildLog extends PhabricatorPHIDType {
 
   const TYPECONST = 'HMCL';
 
-  public function getTypeConstant() {
-    return self::TYPECONST;
-  }
-
   public function getTypeName() {
     return pht('Build Log');
   }

src/applications/harbormaster/phid/HarbormasterPHIDTypeBuildPlan.php

@@ -4,10 +4,6 @@ final class HarbormasterPHIDTypeBuildPlan extends PhabricatorPHIDType {
 
   const TYPECONST = 'HMCP';
 
-  public function getTypeConstant() {
-    return self::TYPECONST;
-  }
-
   public function getTypeName() {
     return pht('Build Plan');
   }

src/applications/harbormaster/phid/HarbormasterPHIDTypeBuildStep.php

@@ -4,10 +4,6 @@ final class HarbormasterPHIDTypeBuildStep extends PhabricatorPHIDType {
 
   const TYPECONST = 'HMCS';
 
-  public function getTypeConstant() {
-    return self::TYPECONST;
-  }
-
   public function getTypeName() {
     return pht('Build Step');
   }

src/applications/harbormaster/phid/HarbormasterPHIDTypeBuildTarget.php

@@ -4,10 +4,6 @@ final class HarbormasterPHIDTypeBuildTarget extends PhabricatorPHIDType {
 
   const TYPECONST = 'HMBT';
 
-  public function getTypeConstant() {
-    return self::TYPECONST;
-  }
-
   public function getTypeName() {
     return pht('Build Target');
   }

src/applications/harbormaster/phid/HarbormasterPHIDTypeBuildable.php

@@ -4,10 +4,6 @@ final class HarbormasterPHIDTypeBuildable extends PhabricatorPHIDType {
 
   const TYPECONST = 'HMBB';
 
-  public function getTypeConstant() {
-    return self::TYPECONST;
-  }
-
   public function getTypeName() {
     return pht('Buildable');
   }

src/applications/herald/phid/HeraldPHIDTypeRule.php

@@ -4,10 +4,6 @@ final class HeraldPHIDTypeRule extends PhabricatorPHIDType {
 
   const TYPECONST = 'HRUL';
 
-  public function getTypeConstant() {
-    return self::TYPECONST;
-  }
-
   public function getTypeName() {
     return pht('Herald Rule');
   }

src/applications/legalpad/phid/PhabricatorLegalpadPHIDTypeDocument.php

@@ -4,10 +4,6 @@ final class PhabricatorLegalpadPHIDTypeDocument extends PhabricatorPHIDType {
 
   const TYPECONST = 'LEGD';
 
-  public function getTypeConstant() {
-    return self::TYPECONST;
-  }
-
   public function getTypeName() {
     return pht('Legalpad Document');
   }

src/applications/macro/phid/PhabricatorMacroPHIDTypeMacro.php

@@ -4,10 +4,6 @@ final class PhabricatorMacroPHIDTypeMacro extends PhabricatorPHIDType {
 
   const TYPECONST = 'MCRO';
 
-  public function getTypeConstant() {
-    return self::TYPECONST;
-  }
-
   public function getTypeName() {
     return pht('Image Macro');
   }

src/applications/mailinglists/phid/PhabricatorMailingListPHIDTypeList.php

@@ -4,10 +4,6 @@ final class PhabricatorMailingListPHIDTypeList extends PhabricatorPHIDType {
 
   const TYPECONST = 'MLST';
 
-  public function getTypeConstant() {
-    return self::TYPECONST;
-  }
-
   public function getTypeName() {
     return pht('Mailing List');
   }

src/applications/maniphest/phid/ManiphestPHIDTypeTask.php

@@ -4,10 +4,6 @@ final class ManiphestPHIDTypeTask extends PhabricatorPHIDType {
 
   const TYPECONST = 'TASK';
 
-  public function getTypeConstant() {
-    return self::TYPECONST;
-  }
-
   public function getTypeName() {
     return pht('Task');
   }

src/applications/meta/phid/PhabricatorApplicationPHIDTypeApplication.php

@@ -5,10 +5,6 @@ final class PhabricatorApplicationPHIDTypeApplication
 
   const TYPECONST = 'APPS';
 
-  public function getTypeConstant() {
-    return self::TYPECONST;
-  }
-
   public function getTypeName() {
     return pht('Application');
   }

src/applications/nuance/phid/NuancePHIDTypeItem.php

@@ -1,14 +1,9 @@
 <?php
 
-final class NuancePHIDTypeItem
+final class NuancePHIDTypeItem extends PhabricatorPHIDType {
-  extends PhabricatorPHIDType {
 
   const TYPECONST = 'NUAI';
 
-  public function getTypeConstant() {
-    return self::TYPECONST;
-  }
-
   public function getTypeName() {
     return pht('Item');
   }

src/applications/nuance/phid/NuancePHIDTypeQueue.php

@@ -5,10 +5,6 @@ final class NuancePHIDTypeQueue
 
   const TYPECONST = 'NUAQ';
 
-  public function getTypeConstant() {
-    return self::TYPECONST;
-  }
-
   public function getTypeName() {
     return pht('Queue');
   }

src/applications/nuance/phid/NuancePHIDTypeRequestor.php

@@ -1,14 +1,9 @@
 <?php
 
-final class NuancePHIDTypeRequestor
+final class NuancePHIDTypeRequestor extends PhabricatorPHIDType {
-  extends PhabricatorPHIDType {
 
   const TYPECONST = 'NUAR';
 
-  public function getTypeConstant() {
-    return self::TYPECONST;
-  }
-
   public function getTypeName() {
     return pht('Requestor');
   }

src/applications/nuance/phid/NuancePHIDTypeSource.php

@@ -1,14 +1,9 @@
 <?php
 
-final class NuancePHIDTypeSource
+final class NuancePHIDTypeSource extends PhabricatorPHIDType {
-  extends PhabricatorPHIDType {
 
   const TYPECONST = 'NUAS';
 
-  public function getTypeConstant() {
-    return self::TYPECONST;
-  }
-
   public function getTypeName() {
     return pht('Source');
   }

src/applications/oauthserver/phid/PhabricatorOAuthServerPHIDTypeClient.php

@@ -5,10 +5,6 @@ final class PhabricatorOAuthServerPHIDTypeClient
 
   const TYPECONST = 'OASC';
 
-  public function getTypeConstant() {
-    return self::TYPECONST;
-  }
-
   public function getTypeName() {
     return pht('OAuth Application');
   }

src/applications/oauthserver/phid/PhabricatorOAuthServerPHIDTypeClientAuthorization.php

@@ -5,10 +5,6 @@ final class PhabricatorOAuthServerPHIDTypeClientAuthorization
 
   const TYPECONST = 'OASA';
 
-  public function getTypeConstant() {
-    return self::TYPECONST;
-  }
-
   public function getTypeName() {
     return pht('OAuth Authorization');
   }

src/applications/owners/phid/PhabricatorOwnersPHIDTypePackage.php

@@ -4,10 +4,6 @@ final class PhabricatorOwnersPHIDTypePackage extends PhabricatorPHIDType {
 
   const TYPECONST = 'OPKG';
 
-  public function getTypeConstant() {
-    return self::TYPECONST;
-  }
-
   public function getTypeName() {
     return pht('Owners Package');
   }

src/applications/passphrase/phid/PassphrasePHIDTypeCredential.php

@@ -4,10 +4,6 @@ final class PassphrasePHIDTypeCredential extends PhabricatorPHIDType {
 
   const TYPECONST = 'CDTL';
 
-  public function getTypeConstant() {
-    return self::TYPECONST;
-  }
-
   public function getTypeName() {
     return pht('Credential');
   }

src/applications/paste/phid/PhabricatorPastePHIDTypePaste.php

@@ -4,10 +4,6 @@ final class PhabricatorPastePHIDTypePaste extends PhabricatorPHIDType {
 
   const TYPECONST = 'PSTE';
 
-  public function getTypeConstant() {
-    return self::TYPECONST;
-  }
-
   public function getTypeName() {
     return pht('Paste');
   }

src/applications/people/phid/PhabricatorPeoplePHIDTypeExternal.php

@@ -4,10 +4,6 @@ final class PhabricatorPeoplePHIDTypeExternal extends PhabricatorPHIDType {
 
   const TYPECONST = 'XUSR';
 
-  public function getTypeConstant() {
-    return self::TYPECONST;
-  }
-
   public function getTypeName() {
     return pht('External Account');
   }

src/applications/people/phid/PhabricatorPeoplePHIDTypeUser.php

@@ -4,10 +4,6 @@ final class PhabricatorPeoplePHIDTypeUser extends PhabricatorPHIDType {
 
   const TYPECONST = 'USER';
 
-  public function getTypeConstant() {
-    return self::TYPECONST;
-  }
-
   public function getTypeName() {
     return pht('User');
   }

src/applications/phame/phid/PhabricatorPhamePHIDTypeBlog.php

@@ -4,10 +4,6 @@ final class PhabricatorPhamePHIDTypeBlog extends PhabricatorPHIDType {
 
   const TYPECONST = 'BLOG';
 
-  public function getTypeConstant() {
-    return self::TYPECONST;
-  }
-
   public function getTypeName() {
     return pht('Phame Blog');
   }

src/applications/phame/phid/PhabricatorPhamePHIDTypePost.php

@@ -4,10 +4,6 @@ final class PhabricatorPhamePHIDTypePost extends PhabricatorPHIDType {
 
   const TYPECONST = 'POST';
 
-  public function getTypeConstant() {
-    return self::TYPECONST;
-  }
-
   public function getTypeName() {
     return pht('Phame Post');
   }

src/applications/phid/type/PhabricatorPHIDType.php

@@ -2,7 +2,28 @@
 
 abstract class PhabricatorPHIDType {
 
-  abstract public function getTypeConstant();
+  final public function getTypeConstant() {
+    $class = new ReflectionClass($this);
+
+    $const = $class->getConstant('TYPECONST');
+    if ($const === false) {
+      throw new Exception(
+        pht(
+          'PHIDType class "%s" must define an TYPECONST property.',
+          get_class($this)));
+    }
+
+    if (!is_string($const) || !preg_match('/^[A-Z]{4}$/', $const)) {
+      throw new Exception(
+        pht(
+          'PHIDType class "%s" has an invalid TYPECONST property. PHID '.
+          'constants must be a four character uppercase string.',
+          get_class($this)));
+    }
+
+    return $const;
+  }
+
   abstract public function getTypeName();
 
   public function newObject() {

src/applications/phlux/phid/PhluxPHIDTypeVariable.php

@@ -4,10 +4,6 @@ final class PhluxPHIDTypeVariable extends PhabricatorPHIDType {
 
   const TYPECONST = 'PVAR';
 
-  public function getTypeConstant() {
-    return self::TYPECONST;
-  }
-
   public function getTypeName() {
     return pht('Variable');
   }

src/applications/pholio/phid/PholioPHIDTypeImage.php

@@ -4,10 +4,6 @@ final class PholioPHIDTypeImage extends PhabricatorPHIDType {
 
   const TYPECONST = 'PIMG';
 
-  public function getTypeConstant() {
-    return self::TYPECONST;
-  }
-
   public function getTypeName() {
     return pht('Image');
   }

src/applications/pholio/phid/PholioPHIDTypeMock.php

@@ -4,10 +4,6 @@ final class PholioPHIDTypeMock extends PhabricatorPHIDType {
 
   const TYPECONST = 'MOCK';
 
-  public function getTypeConstant() {
-    return self::TYPECONST;
-  }
-
   public function getTypeName() {
     return pht('Mock');
   }

src/applications/phragment/phid/PhragmentPHIDTypeFragment.php

@@ -1,14 +1,9 @@
 <?php
 
-final class PhragmentPHIDTypeFragment
+final class PhragmentPHIDTypeFragment extends PhabricatorPHIDType {
-  extends PhabricatorPHIDType {
 
   const TYPECONST = 'PHRF';
 
-  public function getTypeConstant() {
-    return self::TYPECONST;
-  }
-
   public function getTypeName() {
     return pht('Fragment');
   }

src/applications/phragment/phid/PhragmentPHIDTypeFragmentVersion.php

@@ -1,14 +1,9 @@
 <?php
 
-final class PhragmentPHIDTypeFragmentVersion
+final class PhragmentPHIDTypeFragmentVersion extends PhabricatorPHIDType {
-  extends PhabricatorPHIDType {
 
   const TYPECONST = 'PHRV';
 
-  public function getTypeConstant() {
-    return self::TYPECONST;
-  }
-
   public function getTypeName() {
     return pht('Fragment Version');
   }

src/applications/phragment/phid/PhragmentPHIDTypeSnapshot.php

@@ -1,14 +1,9 @@
 <?php
 
-final class PhragmentPHIDTypeSnapshot
+final class PhragmentPHIDTypeSnapshot extends PhabricatorPHIDType {
-  extends PhabricatorPHIDType {
 
   const TYPECONST = 'PHRS';
 
-  public function getTypeConstant() {
-    return self::TYPECONST;
-  }
-
   public function getTypeName() {
     return pht('Snapshot');
   }

src/applications/phriction/phid/PhrictionPHIDTypeDocument.php

@@ -4,10 +4,6 @@ final class PhrictionPHIDTypeDocument extends PhabricatorPHIDType {
 
   const TYPECONST = 'WIKI';
 
-  public function getTypeConstant() {
-    return self::TYPECONST;
-  }
-
   public function getTypeName() {
     return pht('Wiki Document');
   }

src/applications/policy/phid/PhabricatorPolicyPHIDTypePolicy.php

@@ -1,14 +1,9 @@
 <?php
 
-final class PhabricatorPolicyPHIDTypePolicy
+final class PhabricatorPolicyPHIDTypePolicy extends PhabricatorPHIDType {
-  extends PhabricatorPHIDType {
 
   const TYPECONST = 'PLCY';
 
-  public function getTypeConstant() {
-    return self::TYPECONST;
-  }
-
   public function getTypeName() {
     return pht('Policy');
   }

src/applications/ponder/phid/PonderPHIDTypeAnswer.php

@@ -4,10 +4,6 @@ final class PonderPHIDTypeAnswer extends PhabricatorPHIDType {
 
   const TYPECONST = 'ANSW';
 
-  public function getTypeConstant() {
-    return self::TYPECONST;
-  }
-
   public function getTypeName() {
     return pht('Answer');
   }

src/applications/ponder/phid/PonderPHIDTypeQuestion.php

@@ -4,10 +4,6 @@ final class PonderPHIDTypeQuestion extends PhabricatorPHIDType {
 
   const TYPECONST = 'QUES';
 
-  public function getTypeConstant() {
-    return self::TYPECONST;
-  }
-
   public function getTypeName() {
     return pht('Question');
   }

src/applications/project/phid/PhabricatorProjectPHIDTypeColumn.php

@@ -4,10 +4,6 @@ final class PhabricatorProjectPHIDTypeColumn extends PhabricatorPHIDType {
 
   const TYPECONST = 'PCOL';
 
-  public function getTypeConstant() {
-    return self::TYPECONST;
-  }
-
   public function getTypeName() {
     return pht('Project Column');
   }

src/applications/project/phid/PhabricatorProjectPHIDTypeProject.php

@@ -4,10 +4,6 @@ final class PhabricatorProjectPHIDTypeProject extends PhabricatorPHIDType {
 
   const TYPECONST = 'PROJ';
 
-  public function getTypeConstant() {
-    return self::TYPECONST;
-  }
-
   public function getTypeName() {
     return pht('Project');
   }

src/applications/releeph/phid/ReleephPHIDTypeBranch.php

@@ -4,10 +4,6 @@ final class ReleephPHIDTypeBranch extends PhabricatorPHIDType {
 
   const TYPECONST = 'REBR';
 
-  public function getTypeConstant() {
-    return self::TYPECONST;
-  }
-
   public function getTypeName() {
     return pht('Releeph Branch');
   }

src/applications/releeph/phid/ReleephPHIDTypeProduct.php

@@ -4,10 +4,6 @@ final class ReleephPHIDTypeProduct extends PhabricatorPHIDType {
 
   const TYPECONST = 'REPR';
 
-  public function getTypeConstant() {
-    return self::TYPECONST;
-  }
-
   public function getTypeName() {
     return pht('Releeph Product');
   }

src/applications/releeph/phid/ReleephPHIDTypeRequest.php

@@ -4,10 +4,6 @@ final class ReleephPHIDTypeRequest extends PhabricatorPHIDType {
 
   const TYPECONST = 'RERQ';
 
-  public function getTypeConstant() {
-    return self::TYPECONST;
-  }
-
   public function getTypeName() {
     return pht('Releeph Request');
   }

src/applications/repository/phid/PhabricatorRepositoryPHIDTypeArcanistProject.php

@@ -5,10 +5,6 @@ final class PhabricatorRepositoryPHIDTypeArcanistProject
 
   const TYPECONST = 'APRJ';
 
-  public function getTypeConstant() {
-    return self::TYPECONST;
-  }
-
   public function getTypeName() {
     return pht('Arcanist Project');
   }

src/applications/repository/phid/PhabricatorRepositoryPHIDTypeCommit.php

@@ -4,10 +4,6 @@ final class PhabricatorRepositoryPHIDTypeCommit extends PhabricatorPHIDType {
 
   const TYPECONST = 'CMIT';
 
-  public function getTypeConstant() {
-    return self::TYPECONST;
-  }
-
   public function getTypeName() {
     return pht('Commit');
   }

src/applications/repository/phid/PhabricatorRepositoryPHIDTypeMirror.php

@@ -1,14 +1,9 @@
 <?php
 
-final class PhabricatorRepositoryPHIDTypeMirror
+final class PhabricatorRepositoryPHIDTypeMirror extends PhabricatorPHIDType {
-  extends PhabricatorPHIDType {
 
   const TYPECONST = 'RMIR';
 
-  public function getTypeConstant() {
-    return self::TYPECONST;
-  }
-
   public function getTypeName() {
     return pht('Repository Mirror');
   }

src/applications/repository/phid/PhabricatorRepositoryPHIDTypePushEvent.php

@@ -1,14 +1,9 @@
 <?php
 
-final class PhabricatorRepositoryPHIDTypePushEvent
+final class PhabricatorRepositoryPHIDTypePushEvent extends PhabricatorPHIDType {
-  extends PhabricatorPHIDType {
 
   const TYPECONST = 'PSHE';
 
-  public function getTypeConstant() {
-    return self::TYPECONST;
-  }
-
   public function getTypeName() {
     return pht('Push Event');
   }

src/applications/repository/phid/PhabricatorRepositoryPHIDTypePushLog.php

@@ -1,14 +1,9 @@
 <?php
 
-final class PhabricatorRepositoryPHIDTypePushLog
+final class PhabricatorRepositoryPHIDTypePushLog extends PhabricatorPHIDType {
-  extends PhabricatorPHIDType {
 
   const TYPECONST = 'PSHL';
 
-  public function getTypeConstant() {
-    return self::TYPECONST;
-  }
-
   public function getTypeName() {
     return pht('Push Log');
   }

src/applications/repository/phid/PhabricatorRepositoryPHIDTypeRepository.php

@@ -5,10 +5,6 @@ final class PhabricatorRepositoryPHIDTypeRepository
 
   const TYPECONST = 'REPO';
 
-  public function getTypeConstant() {
-    return self::TYPECONST;
-  }
-
   public function getTypeName() {
     return pht('Repository');
   }

src/applications/slowvote/phid/PhabricatorSlowvotePHIDTypePoll.php

@@ -4,10 +4,6 @@ final class PhabricatorSlowvotePHIDTypePoll extends PhabricatorPHIDType {
 
   const TYPECONST = 'POLL';
 
-  public function getTypeConstant() {
-    return self::TYPECONST;
-  }
-
   public function getTypeName() {
     return pht('Slowvote Poll');
   }

src/applications/tokens/phid/PhabricatorTokenPHIDTypeToken.php

@@ -4,10 +4,6 @@ final class PhabricatorTokenPHIDTypeToken extends PhabricatorPHIDType {
 
   const TYPECONST = 'TOKN';
 
-  public function getTypeConstant() {
-    return self::TYPECONST;
-  }
-
   public function getTypeName() {
     return pht('Token');
   }

src/applications/transactions/phid/PhabricatorApplicationTransactionPHIDTypeTransaction.php

@@ -5,10 +5,6 @@ final class PhabricatorApplicationTransactionPHIDTypeTransaction
 
   const TYPECONST = 'XACT';
 
-  public function getTypeConstant() {
-    return self::TYPECONST;
-  }
-
   public function getTypeName() {
     return pht('Transaction');
   }