revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-19 13:22:42 +01:00
Code Issues Releases Wiki Activity

Fix undefined variable warning in unit test field

Browse source 
Summary:
See D1295. $unit_messages may be undefined.

I'll see if I can improve the visibility of warnings, the red dot in DarkConsole
is easy to miss right now. See T734.

Test Plan: Loaded a revision with no unit failures, didn't receive a warning.

Reviewers: nh, btrahan, jungejason

Reviewed By: btrahan

CC: aran, btrahan

Differential Revision: https://secure.phabricator.com/D1306
This commit is contained in:
epriestley 2012-01-04 07:18:16 -08:00
parent 2e9bb62fe7
commit 28b606394b
1 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/differential/field/specification/unit/DifferentialUnitFieldSpecification.php
View file

@ -67,7 +67,6 @@ final class DifferentialUnitFieldSpecification
$postponed_count++; $postponed_count++;
} }
} }
}
if ($unit_messages) { if ($unit_messages) {
$utail = $utail =
'<div class="differential-unit-block">'. '<div class="differential-unit-block">'.
@ -76,6 +75,7 @@ final class DifferentialUnitFieldSpecification
'</ul>'. '</ul>'.
'</div>'; '</div>';
} }
}
if ($postponed_count > 0 && if ($postponed_count > 0 &&
$diff->getUnitStatus() == DifferentialUnitStatus::UNIT_POSTPONED) { $diff->getUnitStatus() == DifferentialUnitStatus::UNIT_POSTPONED) {