revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-20 04:20:55 +01:00
Code Issues Releases Wiki Activity

Hide build target messages if there are no messages for the target

Browse source 
Summary: Ref T1049. This hides the build target messages area if there are no messages for the target.  Since most of the time a build target won't recieve any messages, this area is confusing because it's always empty.

Test Plan: Viewed a build, saw the empty build target message areas disappear.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: epriestley, Korvin

Maniphest Tasks: T1049

Differential Revision: https://secure.phabricator.com/D10092
This commit is contained in:
James Rhodes 2014-08-01 08:08:53 +10:00
parent aa87a524e2
commit 298a30e647
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/applications/harbormaster/controller/HarbormasterBuildViewController.php
View file

@ -97,7 +97,9 @@ final class HarbormasterBuildViewController
->addPropertyList($properties); ->addPropertyList($properties);
$build_messages = idx($messages, $build_target->getPHID(), array()); $build_messages = idx($messages, $build_target->getPHID(), array());
$targets[] = $this->buildMessages($build_messages); if ($build_messages) {
$targets[] = $this->buildMessages($build_messages);
}
$targets[] = $this->buildArtifacts($build_target); $targets[] = $this->buildArtifacts($build_target);
$targets[] = $this->buildLog($build, $build_target); $targets[] = $this->buildLog($build, $build_target);