revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-22 06:42:42 +01:00
Code Issues Releases Wiki Activity

Notification dropdown fixes

Browse source 
Summary: dropdown now displays properly and without flicker

Test Plan: tested locally

Reviewers: epriestley

Reviewed By: epriestley

CC: allenjohnashton, keebuhm, aran, Korvin

Differential Revision: https://secure.phabricator.com/D2708
This commit is contained in:
David Fisher 2012-06-11 17:16:55 -07:00 committed by epriestley
parent 865680ad30
commit 2bade93b76
3 changed files with 4 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/__celerity_resource_map__.php
View file

@ -758,7 +758,7 @@ celerity_register_resource_map(array(
), ),
'javelin-behavior-aphlict-dropdown' => 'javelin-behavior-aphlict-dropdown' =>
array( array(
'uri' => '/res/d0025c08/rsrc/js/application/aphlict/behavior-aphlict-dropdown.js', 'uri' => '/res/40c65741/rsrc/js/application/aphlict/behavior-aphlict-dropdown.js',
'type' => 'js', 'type' => 'js',
'requires' => 'requires' =>
array( array(

5
src/view/page/PhabricatorStandardPageView.php
View file

@ -414,8 +414,9 @@ final class PhabricatorStandardPageView extends AphrontPageView {
'div', 'div',
array( array(
'sigil' => 'aphlict-dropdown', 'sigil' => 'aphlict-dropdown',
'id' => 'phabricator-notification-dropdown', 'id' => 'phabricator-notification-dropdown',
), 'style' => 'display: none',
),
''); '');
} }

3
webroot/rsrc/js/application/aphlict/behavior-aphlict-dropdown.js
View file

@ -12,9 +12,6 @@ JX.behavior('aphlict-dropdown', function(config) {
var indicator = JX.$('phabricator-notification-indicator'); var indicator = JX.$('phabricator-notification-indicator');
var visible = false; var visible = false;
JX.DOM.hide(dropdown);
//populate panel //populate panel
(new JX.Request('/notification/panel/', (new JX.Request('/notification/panel/',
function(response) { function(response) {