revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-26 16:52:41 +01:00
Code Issues Releases Wiki Activity

Remove DifferentialChangesetRenderer->(g|s)etLineCount()

Browse source 
Summary: The "line count" is always the same as count($this->getOldLines()), and somewhat misleading since it's really "number of rows in the two-up view". D4421 removed the only (or only remaining?) call.

Test Plan: looked at some diffs

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2009

Differential Revision: https://secure.phabricator.com/D4422
This commit is contained in:
epriestley 2013-01-14 14:20:26 -08:00
parent 612b29fff4
commit 2de107f21b
2 changed files with 0 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/applications/differential/parser/DifferentialChangesetParser.php
View file

@ -694,7 +694,6 @@ final class DifferentialChangesetParser {
$renderer = $this->getRenderer() $renderer = $this->getRenderer()
->setChangeset($this->changeset) ->setChangeset($this->changeset)
->setRenderPropertyChangeHeader($render_pch) ->setRenderPropertyChangeHeader($render_pch)
->setLineCount($rows)
->setOldRender($this->oldRender) ->setOldRender($this->oldRender)
->setNewRender($this->newRender) ->setNewRender($this->newRender)
->setHunkStartLines($this->hunkStartLines) ->setHunkStartLines($this->hunkStartLines)

9
src/applications/differential/render/DifferentialChangesetRenderer.php
View file

@ -27,15 +27,6 @@ abstract class DifferentialChangesetRenderer {
private $gaps; private $gaps;
private $mask; private $mask;
private $depths; private $depths;
private $lineCount;
public function setLineCount($line_count) {
$this->lineCount = $line_count;
return $this;
}
public function getLineCount() {
return $this->lineCount;
}
public function setDepths($depths) { public function setDepths($depths) {
$this->depths = $depths; $this->depths = $depths;