Remove DifferentialChangesetRenderer->(g|s)etLineCount()

Summary: The "line count" is always the same as count($this->getOldLines()), and somewhat misleading since it's really "number of rows in the two-up view". D4421 removed the only (or only remaining?) call.

Test Plan: looked at some diffs

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2009

Differential Revision: https://secure.phabricator.com/D4422

src/applications/differential/parser/DifferentialChangesetParser.php

@@ -694,7 +694,6 @@ final class DifferentialChangesetParser {
     $renderer = $this->getRenderer()
       ->setChangeset($this->changeset)
       ->setRenderPropertyChangeHeader($render_pch)
-      ->setLineCount($rows)
       ->setOldRender($this->oldRender)
       ->setNewRender($this->newRender)
       ->setHunkStartLines($this->hunkStartLines)

src/applications/differential/render/DifferentialChangesetRenderer.php

@@ -27,15 +27,6 @@ abstract class DifferentialChangesetRenderer {
   private $gaps;
   private $mask;
   private $depths;
-  private $lineCount;
-
-  public function setLineCount($line_count) {
-    $this->lineCount = $line_count;
-    return $this;
-  }
-  public function getLineCount() {
-    return $this->lineCount;
-  }
 
   public function setDepths($depths) {
     $this->depths = $depths;