revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-27 01:02:42 +01:00
Code Issues Releases Wiki Activity

Make DiffusionQuery extend PhabricatorQuery

Browse source 
Summary: Ref T2683. Provides access to `formatWhereClause()`, etc. I plan to eventually unify the various DiffusionQuery execute methods as well, which all have special names right now (`loadModifiedPaths()`, `loadWhateverBlah()`, etc).

Test Plan: Ran EverythingImplemented test. Browsed Diffusion.

Reviewers: vrana

Reviewed By: vrana

CC: aran

Maniphest Tasks: T2683

Differential Revision: https://secure.phabricator.com/D5251
This commit is contained in:
epriestley 2013-04-30 10:54:02 -07:00
parent 7ad2eae47f
commit 2ed29980db
2 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/__phutil_library_map__.php
View file

@ -2224,6 +2224,7 @@ phutil_register_library_map(array(
'DiffusionPathQueryTestCase' => 'PhabricatorTestCase',
'DiffusionPathValidateController' => 'DiffusionController',
'DiffusionPeopleMenuEventListener' => 'PhutilEventListener',
'DiffusionQuery' => 'PhabricatorQuery',
'DiffusionRawDiffQuery' => 'DiffusionQuery',
'DiffusionRemarkupRule' => 'PhabricatorRemarkupRuleObject',
'DiffusionRepositoryController' => 'DiffusionController',

6
src/applications/diffusion/query/DiffusionQuery.php
View file

@ -1,6 +1,6 @@
<?php
abstract class DiffusionQuery {
abstract class DiffusionQuery extends PhabricatorQuery {
private $request;
@ -36,6 +36,10 @@ abstract class DiffusionQuery {
return $this->request;
}
public function execute() {
return $this->executeQuery();
}
abstract protected function executeQuery();