revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-19 03:50:54 +01:00
Code Issues Releases Wiki Activity

Fix a bad %d for PHID

Browse source 
Summary: D1174 caught this issue -- we mean to load all //your// rules, but
actually load //all// rules. Use %s correctly.

Test Plan: Hit /herald/rule/ without an exception.

Reviewers: fmoo, btrahan, jungejason

Reviewed By: btrahan

CC: aran, epriestley, btrahan

Differential Revision: 1203
This commit is contained in:
epriestley 2011-12-13 18:28:35 -08:00
parent 6f1dfbb658
commit 2efd8fe971
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/herald/controller/rule/HeraldRuleController.php
View file

@ -376,7 +376,7 @@ class HeraldRuleController extends HeraldController {
} }
$all_rules = id(new HeraldRule())->loadAllWhere( $all_rules = id(new HeraldRule())->loadAllWhere(
'authorPHID = %d AND contentType = %s', 'authorPHID = %s AND contentType = %s',
$rule->getAuthorPHID(), $rule->getAuthorPHID(),
$rule->getContentType()); $rule->getContentType());
$all_rules = mpull($all_rules, 'getName', 'getID'); $all_rules = mpull($all_rules, 'getName', 'getID');