revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-30 01:10:58 +01:00
Code Issues Releases Wiki Activity

Bump number of visible Maniphest tags to 4 (from 2)

Browse source 
Summary: Ref T3574. Since this list just clips in a totally reasonable way on mobile and we got another user request for it, let's bump this to 4 for now and we can refine mobile later.

Test Plan: Looked at list on desktop; saw 4 tags before truncation. Looked at list on mobile, saw reasonable clipping behavior which didn't mar usability.

Reviewers: chad, btrahan

Reviewed By: chad

CC: aran

Maniphest Tasks: T3574

Differential Revision: https://secure.phabricator.com/D8213
This commit is contained in:
epriestley 2014-02-13 10:05:47 -08:00
parent 646d137fd2
commit 30ffe0ce5d
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/applications/maniphest/view/ManiphestTaskProjectsView.php
View file

@ -15,9 +15,9 @@ final class ManiphestTaskProjectsView extends ManiphestView {
public function render() {
require_celerity_resource('phabricator-project-tag-css');
$max_visible_tags = 4;
$show = array_slice($this->handles, 0, 2);
$show = array_slice($this->handles, 0, $max_visible_tags);
$tags = array();
if ($show) {
@ -39,7 +39,7 @@ final class ManiphestTaskProjectsView extends ManiphestView {
pht('No Project'));
}
if (count($this->handles) > 2) {
if (count($this->handles) > $max_visible_tags) {
require_celerity_resource('aphront-tooltip-css');
Javelin::initBehavior('phabricator-tooltips');