revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-03-10 19:34:51 +01:00
Code Issues Releases Wiki Activity

Fix non-existing log method in HarbormasterManagementRestartWorkflow

Browse source 
Summary: In `HarbormasterManagementRestartWorkflow`, `logSkip()` is called. A method with such a name has never existed in `PhabricatorManagementWorkflow`. Given the five available `log*()` methods, replace the call with `logInfo()` which seems most appropriate.

Test Plan: Run static code analysis which complains about `Call to an undefined method HarbormasterManagementRestartWorkflow::logSkip()`; read the code.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Tags: #almanac_drydock_harbormaster

Differential Revision: https://we.phorge.it/D25742
This commit is contained in:
Andre Klapper 2024-07-24 18:35:31 +02:00
parent 0f4ab2413d
commit 38e359cb13
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/harbormaster/management/HarbormasterManagementRestartWorkflow.php
View file

@ -50,7 +50,7 @@ final class HarbormasterManagementRestartWorkflow
$count = count($builds);
if (!$count) {
$this->logSkip(
$this->logInfo(
pht('SKIP'),
pht('No builds to restart.'));
return 0;