1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-19 12:00:55 +01:00

Don't show 'needs review' on DifferentialObjects

Summary:
This text is overly repetitive and is not super important. Keeps the other states. Also

- Easier to parse reviewers now
- Mobile is less janky

Test Plan:
reload my list of diffs

{F138756}

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D8707
This commit is contained in:
Chad Little 2014-04-04 14:00:28 -07:00
parent c408168c25
commit 3b33089de7

View file

@ -138,7 +138,10 @@ final class DifferentialRevisionListView extends AphrontView {
$item->addAttribute($draft);
}
$item->addAttribute($status_name);
/* Most things 'Need Review', so accept it's the default */
if ($status != ArcanistDifferentialRevisionStatus::NEEDS_REVIEW) {
$item->addAttribute($status_name);
}
// Author
$author_handle = $this->handles[$revision->getAuthorPHID()];