mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-22 23:02:42 +01:00
Completely remove "differential.find" Conduit API method
Summary: Ref T2543. I believe there have been no upstream callsites of this method since D1646, in February 2012. The method works, and we can revert this if needbe, but this seems like a good time to remove support. Test Plan: Grepped for `differential.find`. Reviewers: chad Reviewed By: chad Maniphest Tasks: T2543 Differential Revision: https://secure.phabricator.com/D18397
This commit is contained in:
parent
13ddb15bbc
commit
42020e1357
2 changed files with 0 additions and 101 deletions
|
@ -445,7 +445,6 @@ phutil_register_library_map(array(
|
||||||
'DifferentialExactUserFunctionDatasource' => 'applications/differential/typeahead/DifferentialExactUserFunctionDatasource.php',
|
'DifferentialExactUserFunctionDatasource' => 'applications/differential/typeahead/DifferentialExactUserFunctionDatasource.php',
|
||||||
'DifferentialFieldParseException' => 'applications/differential/exception/DifferentialFieldParseException.php',
|
'DifferentialFieldParseException' => 'applications/differential/exception/DifferentialFieldParseException.php',
|
||||||
'DifferentialFieldValidationException' => 'applications/differential/exception/DifferentialFieldValidationException.php',
|
'DifferentialFieldValidationException' => 'applications/differential/exception/DifferentialFieldValidationException.php',
|
||||||
'DifferentialFindConduitAPIMethod' => 'applications/differential/conduit/DifferentialFindConduitAPIMethod.php',
|
|
||||||
'DifferentialGetAllDiffsConduitAPIMethod' => 'applications/differential/conduit/DifferentialGetAllDiffsConduitAPIMethod.php',
|
'DifferentialGetAllDiffsConduitAPIMethod' => 'applications/differential/conduit/DifferentialGetAllDiffsConduitAPIMethod.php',
|
||||||
'DifferentialGetCommitMessageConduitAPIMethod' => 'applications/differential/conduit/DifferentialGetCommitMessageConduitAPIMethod.php',
|
'DifferentialGetCommitMessageConduitAPIMethod' => 'applications/differential/conduit/DifferentialGetCommitMessageConduitAPIMethod.php',
|
||||||
'DifferentialGetCommitPathsConduitAPIMethod' => 'applications/differential/conduit/DifferentialGetCommitPathsConduitAPIMethod.php',
|
'DifferentialGetCommitPathsConduitAPIMethod' => 'applications/differential/conduit/DifferentialGetCommitPathsConduitAPIMethod.php',
|
||||||
|
@ -5419,7 +5418,6 @@ phutil_register_library_map(array(
|
||||||
'DifferentialExactUserFunctionDatasource' => 'PhabricatorTypeaheadCompositeDatasource',
|
'DifferentialExactUserFunctionDatasource' => 'PhabricatorTypeaheadCompositeDatasource',
|
||||||
'DifferentialFieldParseException' => 'Exception',
|
'DifferentialFieldParseException' => 'Exception',
|
||||||
'DifferentialFieldValidationException' => 'Exception',
|
'DifferentialFieldValidationException' => 'Exception',
|
||||||
'DifferentialFindConduitAPIMethod' => 'DifferentialConduitAPIMethod',
|
|
||||||
'DifferentialGetAllDiffsConduitAPIMethod' => 'DifferentialConduitAPIMethod',
|
'DifferentialGetAllDiffsConduitAPIMethod' => 'DifferentialConduitAPIMethod',
|
||||||
'DifferentialGetCommitMessageConduitAPIMethod' => 'DifferentialConduitAPIMethod',
|
'DifferentialGetCommitMessageConduitAPIMethod' => 'DifferentialConduitAPIMethod',
|
||||||
'DifferentialGetCommitPathsConduitAPIMethod' => 'DifferentialConduitAPIMethod',
|
'DifferentialGetCommitPathsConduitAPIMethod' => 'DifferentialConduitAPIMethod',
|
||||||
|
|
|
@ -1,99 +0,0 @@
|
||||||
<?php
|
|
||||||
|
|
||||||
final class DifferentialFindConduitAPIMethod
|
|
||||||
extends DifferentialConduitAPIMethod {
|
|
||||||
|
|
||||||
public function getAPIMethodName() {
|
|
||||||
return 'differential.find';
|
|
||||||
}
|
|
||||||
|
|
||||||
public function getMethodStatus() {
|
|
||||||
return self::METHOD_STATUS_DEPRECATED;
|
|
||||||
}
|
|
||||||
|
|
||||||
public function getMethodStatusDescription() {
|
|
||||||
return pht("Replaced by '%s'.", 'differential.query');
|
|
||||||
}
|
|
||||||
|
|
||||||
public function getMethodDescription() {
|
|
||||||
return pht('Query Differential revisions which match certain criteria.');
|
|
||||||
}
|
|
||||||
|
|
||||||
protected function defineParamTypes() {
|
|
||||||
$types = array(
|
|
||||||
'open',
|
|
||||||
'committable',
|
|
||||||
'revision-ids',
|
|
||||||
'phids',
|
|
||||||
);
|
|
||||||
|
|
||||||
return array(
|
|
||||||
'query' => 'required '.$this->formatStringConstants($types),
|
|
||||||
'guids' => 'required nonempty list<guids>',
|
|
||||||
);
|
|
||||||
}
|
|
||||||
|
|
||||||
protected function defineReturnType() {
|
|
||||||
return 'nonempty list<dict>';
|
|
||||||
}
|
|
||||||
|
|
||||||
protected function execute(ConduitAPIRequest $request) {
|
|
||||||
$type = $request->getValue('query');
|
|
||||||
$guids = $request->getValue('guids');
|
|
||||||
|
|
||||||
$results = array();
|
|
||||||
if (!$guids) {
|
|
||||||
return $results;
|
|
||||||
}
|
|
||||||
|
|
||||||
$query = id(new DifferentialRevisionQuery())
|
|
||||||
->setViewer($request->getUser());
|
|
||||||
|
|
||||||
switch ($type) {
|
|
||||||
case 'open':
|
|
||||||
$query
|
|
||||||
->withIsOpen(true)
|
|
||||||
->withAuthors($guids);
|
|
||||||
break;
|
|
||||||
case 'committable':
|
|
||||||
$query
|
|
||||||
->withStatuses(DifferentialRevisionStatus::ACCEPTED)
|
|
||||||
->withAuthors($guids);
|
|
||||||
break;
|
|
||||||
case 'revision-ids':
|
|
||||||
$query
|
|
||||||
->withIDs($guids);
|
|
||||||
break;
|
|
||||||
case 'owned':
|
|
||||||
$query->withAuthors($guids);
|
|
||||||
break;
|
|
||||||
case 'phids':
|
|
||||||
$query
|
|
||||||
->withPHIDs($guids);
|
|
||||||
break;
|
|
||||||
}
|
|
||||||
|
|
||||||
$revisions = $query->execute();
|
|
||||||
|
|
||||||
foreach ($revisions as $revision) {
|
|
||||||
$diff = $revision->loadActiveDiff();
|
|
||||||
if (!$diff) {
|
|
||||||
continue;
|
|
||||||
}
|
|
||||||
$id = $revision->getID();
|
|
||||||
$results[] = array(
|
|
||||||
'id' => $id,
|
|
||||||
'phid' => $revision->getPHID(),
|
|
||||||
'name' => $revision->getTitle(),
|
|
||||||
'uri' => PhabricatorEnv::getProductionURI('/D'.$id),
|
|
||||||
'dateCreated' => $revision->getDateCreated(),
|
|
||||||
'authorPHID' => $revision->getAuthorPHID(),
|
|
||||||
'statusName' => $revision->getStatusDisplayName(),
|
|
||||||
'sourcePath' => $diff->getSourcePath(),
|
|
||||||
);
|
|
||||||
}
|
|
||||||
|
|
||||||
return $results;
|
|
||||||
}
|
|
||||||
|
|
||||||
}
|
|
Loading…
Reference in a new issue