revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-22 05:20:56 +01:00
Code Issues Releases Wiki Activity

Use PhutilProxyException to disambiguate work queue failures

Browse source 
Summary: Fixes T2569. This is the other common exception source which is ambiguous. List the task ID explicitly to make debugging easier.

Test Plan: {F51268}

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2569

Differential Revision: https://secure.phabricator.com/D6549
This commit is contained in:
epriestley 2013-07-23 12:57:28 -07:00
parent 938b5c69c6
commit 45db6001ea
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/infrastructure/daemon/workers/PhabricatorTaskmasterDaemon.php
View file

@ -23,7 +23,9 @@ final class PhabricatorTaskmasterDaemon extends PhabricatorDaemon {
$this->log("Task {$id} failed permanently."); $this->log("Task {$id} failed permanently.");
} else { } else {
$this->log("Task {$id} failed!"); $this->log("Task {$id} failed!");
throw $ex; throw new PhutilProxyException(
"Error while executing task ID {$id} from queue.",
$ex);
} }
} else { } else {
$this->log("Task {$id} complete! Moved to archive."); $this->log("Task {$id} complete! Moved to archive.");