revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-23 22:10:55 +01:00
Code Issues Releases Wiki Activity

Clarify that the "Add Comment" button might not literally add a comment if you haven't typed a comment

Browse source 
Summary: Ref T9908.

Test Plan: Careful reading.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9908

Differential Revision: https://secure.phabricator.com/D14746
This commit is contained in:
epriestley 2015-12-11 17:03:10 -08:00
parent dbdd702702
commit 4b77bbd60c
3 changed files with 35 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/applications/maniphest/editor/ManiphestEditEngine.php
View file

@ -42,12 +42,11 @@ final class ManiphestEditEngine
} }
protected function getCommentViewHeaderText($object) { protected function getCommentViewHeaderText($object) {
$is_serious = PhabricatorEnv::getEnvConfig('phabricator.serious-business'); return pht('Weigh In');
if (!$is_serious) { }
return pht('Weigh In');
}
return parent::getCommentViewHeaderText($object); protected function getCommentViewButtonText($object) {
return pht('Set Sail for Adventure');
} }
protected function getObjectViewURI($object) { protected function getObjectViewURI($object) {

9
src/applications/paste/editor/PhabricatorPasteEditEngine.php
View file

@ -39,12 +39,11 @@ final class PhabricatorPasteEditEngine
} }
protected function getCommentViewHeaderText($object) { protected function getCommentViewHeaderText($object) {
$is_serious = PhabricatorEnv::getEnvConfig('phabricator.serious-business'); return pht('Eat Paste');
if (!$is_serious) { }
return pht('Eat Paste');
}
return parent::getCommentViewHeaderText($object); protected function getCommentViewButtonText($object) {
return pht('Nom Nom Nom Nom Nom');
} }
protected function getObjectViewURI($object) { protected function getObjectViewURI($object) {

31
src/applications/transactions/editengine/PhabricatorEditEngine.php
View file

@ -169,11 +169,27 @@ abstract class PhabricatorEditEngine
} }
/**
* @task text
*/
protected function getCommentViewSeriousHeaderText($object) {
return pht('Take Action');
}
/**
* @task text
*/
protected function getCommentViewSeriousButtonText($object) {
return pht('Submit');
}
/** /**
* @task text * @task text
*/ */
protected function getCommentViewHeaderText($object) { protected function getCommentViewHeaderText($object) {
return pht('Add Comment'); return $this->getCommentViewSeriousHeaderText($object);
} }
@ -181,7 +197,7 @@ abstract class PhabricatorEditEngine
* @task text * @task text
*/ */
protected function getCommentViewButtonText($object) { protected function getCommentViewButtonText($object) {
return pht('Add Comment'); return $this->getCommentViewSeriousButtonText($object);
} }
@ -1125,8 +1141,15 @@ abstract class PhabricatorEditEngine
$viewer = $this->getViewer(); $viewer = $this->getViewer();
$object_phid = $object->getPHID(); $object_phid = $object->getPHID();
$header_text = $this->getCommentViewHeaderText($object); $is_serious = PhabricatorEnv::getEnvConfig('phabricator.serious-business');
$button_text = $this->getCommentViewButtonText($object);
if ($is_serious) {
$header_text = $this->getCommentViewSeriousHeaderText($object);
$button_text = $this->getCommentViewSeriousButtonText($object);
} else {
$header_text = $this->getCommentViewHeaderText($object);
$button_text = $this->getCommentViewButtonText($object);
}
$comment_uri = $this->getEditURI($object, 'comment/'); $comment_uri = $this->getEditURI($object, 'comment/');