mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-22 21:40:55 +01:00
Improve commit audit status icons
Summary: Ref T9482. These may need a little more work (feel free to shoot me a counter-diff) but try to: - Never use only color to distinguish between states (for colorblind, etc users). - Give the "nothing needs to be done" state a more obvious "okay" icon (instead of a question mark). Test Plan: Looked at some linked commits in Maniphest, the icons made a bit more sense? Reviewers: chad Reviewed By: chad Maniphest Tasks: T9482 Differential Revision: https://secure.phabricator.com/D17203
This commit is contained in:
parent
103d8c45f3
commit
4d0a03e3d0
1 changed files with 11 additions and 3 deletions
|
@ -10,7 +10,7 @@ final class PhabricatorAuditCommitStatusConstants extends Phobject {
|
|||
|
||||
public static function getStatusNameMap() {
|
||||
$map = array(
|
||||
self::NONE => pht('None'),
|
||||
self::NONE => pht('No Audits'),
|
||||
self::NEEDS_AUDIT => pht('Audit Required'),
|
||||
self::CONCERN_RAISED => pht('Concern Raised'),
|
||||
self::PARTIALLY_AUDITED => pht('Partially Audited'),
|
||||
|
@ -46,6 +46,9 @@ final class PhabricatorAuditCommitStatusConstants extends Phobject {
|
|||
case self::FULLY_AUDITED:
|
||||
$color = 'green';
|
||||
break;
|
||||
case self::NONE:
|
||||
$color = 'bluegrey';
|
||||
break;
|
||||
default:
|
||||
$color = null;
|
||||
break;
|
||||
|
@ -56,13 +59,18 @@ final class PhabricatorAuditCommitStatusConstants extends Phobject {
|
|||
public static function getStatusIcon($code) {
|
||||
switch ($code) {
|
||||
case self::CONCERN_RAISED:
|
||||
$icon = 'fa-exclamation-circle';
|
||||
$icon = 'fa-times-circle';
|
||||
break;
|
||||
case self::NEEDS_AUDIT:
|
||||
case self::PARTIALLY_AUDITED:
|
||||
$icon = 'fa-exclamation-circle';
|
||||
break;
|
||||
case self::PARTIALLY_AUDITED:
|
||||
$icon = 'fa-check-circle-o';
|
||||
break;
|
||||
case self::FULLY_AUDITED:
|
||||
$icon = 'fa-check-circle';
|
||||
break;
|
||||
case self::NONE:
|
||||
$icon = 'fa-check';
|
||||
break;
|
||||
default:
|
||||
|
|
Loading…
Reference in a new issue