revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-23 05:50:55 +01:00
Code Issues Releases Wiki Activity

Improve commit audit status icons

Browse source 
Summary:
Ref T9482. These may need a little more work (feel free to shoot me a counter-diff) but try to:

  - Never use only color to distinguish between states (for colorblind, etc users).
  - Give the "nothing needs to be done" state a more obvious "okay" icon (instead of a question mark).

Test Plan: Looked at some linked commits in Maniphest, the icons made a bit more sense?

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9482

Differential Revision: https://secure.phabricator.com/D17203
This commit is contained in:
epriestley 2017-01-12 16:31:33 -08:00
parent 103d8c45f3
commit 4d0a03e3d0
1 changed files with 11 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
src/applications/audit/constants/PhabricatorAuditCommitStatusConstants.php
View file

@ -10,7 +10,7 @@ final class PhabricatorAuditCommitStatusConstants extends Phobject {
public static function getStatusNameMap() { public static function getStatusNameMap() {
$map = array( $map = array(
self::NONE => pht('None'), self::NONE => pht('No Audits'),
self::NEEDS_AUDIT => pht('Audit Required'), self::NEEDS_AUDIT => pht('Audit Required'),
self::CONCERN_RAISED => pht('Concern Raised'), self::CONCERN_RAISED => pht('Concern Raised'),
self::PARTIALLY_AUDITED => pht('Partially Audited'), self::PARTIALLY_AUDITED => pht('Partially Audited'),
@ -46,6 +46,9 @@ final class PhabricatorAuditCommitStatusConstants extends Phobject {
case self::FULLY_AUDITED: case self::FULLY_AUDITED:
$color = 'green'; $color = 'green';
break; break;
case self::NONE:
$color = 'bluegrey';
break;
default: default:
$color = null; $color = null;
break; break;
@ -56,13 +59,18 @@ final class PhabricatorAuditCommitStatusConstants extends Phobject {
public static function getStatusIcon($code) { public static function getStatusIcon($code) {
switch ($code) { switch ($code) {
case self::CONCERN_RAISED: case self::CONCERN_RAISED:
$icon = 'fa-exclamation-circle'; $icon = 'fa-times-circle';
break; break;
case self::NEEDS_AUDIT: case self::NEEDS_AUDIT:
case self::PARTIALLY_AUDITED:
$icon = 'fa-exclamation-circle'; $icon = 'fa-exclamation-circle';
break; break;
case self::PARTIALLY_AUDITED:
$icon = 'fa-check-circle-o';
break;
case self::FULLY_AUDITED: case self::FULLY_AUDITED:
$icon = 'fa-check-circle';
break;
case self::NONE:
$icon = 'fa-check'; $icon = 'fa-check';
break; break;
default: default: