revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-09 14:21:02 +01:00
Code Issues Releases Wiki Activity

(stable) Fix inverted check in audit triggers for "uninvolved owner"

Browse source 
Summary: See D20126. I was trying to be a little too cute here with the names and ended up confusing myself, then just tested the method behavior. :/

Test Plan: Persudaded by arguments in D20126.

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D20135
This commit is contained in:
epriestley 2019-02-11 06:55:23 -08:00
parent 905564db6b
commit 4f40cb0ff9
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/applications/repository/worker/PhabricatorRepositoryCommitOwnersWorker.php
View file

@ -174,12 +174,12 @@ final class PhabricatorRepositoryCommitOwnersWorker
// If auditing is configured to trigger on changes with no involved owner, // If auditing is configured to trigger on changes with no involved owner,
// check for an owner. If we don't find one, trigger an audit. // check for an owner. If we don't find one, trigger an audit.
if ($audit_uninvolved) { if ($audit_uninvolved) {
$commit_uninvolved = $this->isOwnerInvolved( $owner_involved = $this->isOwnerInvolved(
$commit, $commit,
$package, $package,
$author_phid, $author_phid,
$revision); $revision);
if ($commit_uninvolved) { if (!$owner_involved) {
return true; return true;
} }
} }