revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-22 06:42:42 +01:00
Code Issues Releases Wiki Activity

Fix PHP 8.1 "strlen(null)" exception for "/bin/storage renamespace" without parameter

Browse source 
Summary:
`strlen()` was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

This patch also fixes two similar strlen() occurrences in the same source file.

```
ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementRenamespaceWorkflow.php:62]
```

Test Plan: Run `../phorge/bin/storage renamespace`: Get no `strlen()` error anymore but only expected output `Usage Exception: Specify the dumpfile to read with "--input", or use "--live" to generate one automatically.`

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Differential Revision: https://we.phorge.it/D25592
This commit is contained in:
Andre Klapper 2024-04-17 13:12:24 +02:00
parent 5fe2fc33fb
commit 5444e1c885
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/infrastructure/storage/management/workflow/PhabricatorStorageManagementRenamespaceWorkflow.php
View file

@ -59,7 +59,7 @@ final class PhabricatorStorageManagementRenamespaceWorkflow
$input = $args->getArg('input'); $input = $args->getArg('input');
$is_live = $args->getArg('live'); $is_live = $args->getArg('live');
if (!strlen($input) && !$is_live) { if (!phutil_nonempty_string($input) && !$is_live) {
throw new PhutilArgumentUsageException( throw new PhutilArgumentUsageException(
pht( pht(
'Specify the dumpfile to read with "--input", or use "--live" to '. 'Specify the dumpfile to read with "--input", or use "--live" to '.
@ -67,7 +67,7 @@ final class PhabricatorStorageManagementRenamespaceWorkflow
} }
$from = $args->getArg('from'); $from = $args->getArg('from');
if (!strlen($from)) { if (!phutil_nonempty_string($from)) {
throw new PhutilArgumentUsageException( throw new PhutilArgumentUsageException(
pht( pht(
'Specify namespace to rename from with %s.', 'Specify namespace to rename from with %s.',
@ -75,7 +75,7 @@ final class PhabricatorStorageManagementRenamespaceWorkflow
} }
$to = $args->getArg('to'); $to = $args->getArg('to');
if (!strlen($to)) { if (!phutil_nonempty_string($to)) {
throw new PhutilArgumentUsageException( throw new PhutilArgumentUsageException(
pht( pht(
'Specify namespace to rename to with %s.', 'Specify namespace to rename to with %s.',