revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-10 23:01:04 +01:00
Code Issues Releases Wiki Activity

Fix an issue where known Subversion commits are incorrectly shown as "Discovering..."

Browse source 
Summary:
Ref T13552. The behavior of "RepositoryQuery" with ambiguous identifiers under "withRepositoryPHIDs()" is tricky. This leads to failure to load commits in Subversion in some cases.

Use "withRepository()", which gives us the correct identifier resolution behavior.

Test Plan: Viewed a subversion repository history in Diffusion, saw commit details after change.

Maniphest Tasks: T13552

Differential Revision: https://secure.phabricator.com/D21469
This commit is contained in:
epriestley 2020-09-17 13:50:24 -07:00
parent f21a00a315
commit 58d3f6145a
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/diffusion/view/DiffusionCommitGraphView.php
View file

@ -614,7 +614,7 @@ final class DiffusionCommitGraphView
$commits = id(new DiffusionCommitQuery())
->setViewer($viewer)
->withRepositoryPHIDs(array($repository->getPHID()))
->withRepository($repository)
->withIdentifiers($identifiers)
->needCommitData(true)
->needIdentities(true)