revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-22 14:52:41 +01:00
Code Issues Releases Wiki Activity

Fix an outdated HTML anchor link in Diffusion table of contents

Browse source 
Summary:
See <https://discourse.phabricator-community.org/t/navigating-to-changed-files-in-diffusion-does-not-work-anymore/433>.

In D18465, I updated these but this hard-coded the anchor for some reason (???) and I missed it while `grep`-ing.

Test Plan: Viewed a commit (`/rXYZaaaa`) and clicked a file link in the table of contents. Got modern `#change-...` anchor and navigation into the document.

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D18609
This commit is contained in:
epriestley 2017-09-15 05:33:08 -07:00
parent c71cb944a4
commit 5ae3af6691
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/diffusion/controller/DiffusionCommitController.php
View file

@ -946,7 +946,7 @@ final class DiffusionCommitController extends DiffusionController {
foreach ($changesets as $changeset_id => $changeset) { foreach ($changesets as $changeset_id => $changeset) {
$path = $changeset->getFilename(); $path = $changeset->getFilename();
$anchor = substr(md5($path), 0, 8); $anchor = $changeset->getAnchorName();
$history_link = $diffusion_view->linkHistory($path); $history_link = $diffusion_view->linkHistory($path);
$browse_link = $diffusion_view->linkBrowse( $browse_link = $diffusion_view->linkBrowse(