Declare used properties

Summary: Also fix couple of other errors.

Test Plan: Executed controllers.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D3627

src/aphront/configuration/AphrontDefaultApplicationConfiguration.php

@@ -121,11 +121,6 @@ class AphrontDefaultApplicationConfiguration
         '' => 'DrydockResourceListController',
         'resource/' => 'DrydockResourceListController',
         'resource/allocate/' => 'DrydockResourceAllocateController',
-        'host/' => array(
-          '' => 'DrydockHostListController',
-          'edit/' => 'DrydockHostEditController',
-          'edit/(?P<id>\d+)/' => 'DrydockhostEditController',
-        ),
         'lease/' => 'DrydockLeaseListController',
         'log/' => 'DrydockLogController',
       ),

src/applications/auth/controller/PhabricatorOAuthDiagnosticsController.php

@@ -19,6 +19,8 @@
 final class PhabricatorOAuthDiagnosticsController
   extends PhabricatorAuthController {
 
+  private $provider;
+
   public function shouldRequireLogin() {
     return false;
   }

src/applications/countdown/controller/PhabricatorCountdownDeleteController.php

@@ -19,6 +19,8 @@
 final class PhabricatorCountdownDeleteController
   extends PhabricatorCountdownController {
 
+  private $id;
+
   public function willProcessRequest(array $data) {
     $this->id = $data['id'];
   }

src/applications/herald/storage/HeraldRule.php

@@ -32,6 +32,8 @@ final class HeraldRule extends HeraldDAO {
 
   private $ruleApplied = array(); // phids for which this rule has been applied
   private $invalidOwner = false;
+  private $conditions;
+  private $actions;
 
   public static function loadAllByContentTypeWithFullData(
     $content_type,

src/applications/herald/view/HeraldRuleEditHistoryView.php

@@ -20,6 +20,7 @@ final class HeraldRuleEditHistoryView extends AphrontView {
 
   private $edits;
   private $handles;
+  private $user;
 
   public function setEdits(array $edits) {
     $this->edits = $edits;

src/applications/ponder/controller/PonderFeedController.php

@@ -24,7 +24,6 @@ final class PonderFeedController extends PonderController {
 
   public function willProcessRequest(array $data) {
     $this->page = idx($data, 'page');
-    $this->feedOffset = idx($data, 'feedoffset');
   }
 
   public function processRequest() {
@@ -81,14 +80,10 @@ final class PonderFeedController extends PonderController {
           self::PROFILE_ANSWER_PAGE_SIZE + 1
         );
 
-        $phids = array($user->getPHID());
-        $handles = $this->loadViewerHandles($phids);
-
         $side_nav->appendChild(
           id(new PonderUserProfileView())
           ->setUser($user)
           ->setAnswers($answers)
-          ->setHandles($handles)
           ->setAnswerOffset($this->answerOffset)
           ->setPageSize(self::PROFILE_ANSWER_PAGE_SIZE)
           ->setURI(new PhutilURI("/ponder/profile/"), "aoff")

src/applications/ponder/view/PonderUserProfileView.php

@@ -50,11 +50,6 @@ final class PonderUserProfileView extends AphrontView {
     return $this;
   }
 
-  public function setHandles($handles) {
-    $this->handles = $handles;
-    return $this;
-  }
-
   public function setURI($uri, $aparam) {
     $this->uri = $uri;
     $this->aparam = $aparam;
@@ -68,7 +63,6 @@ final class PonderUserProfileView extends AphrontView {
     $user     = $this->user;
     $aoffset  = $this->answeroffset;
     $answers  = $this->answers;
-    $handles  = $this->handles;
     $uri      = $this->uri;
     $aparam   = $this->aparam;
     $pagesize = $this->pagesize;

src/applications/project/controller/PhabricatorProjectMembersEditController.php

@@ -19,6 +19,8 @@
 final class PhabricatorProjectMembersEditController
   extends PhabricatorProjectController {
 
+  private $id;
+
   public function willProcessRequest(array $data) {
     $this->id = $data['id'];
   }

src/applications/project/controller/PhabricatorProjectProfileEditController.php

@@ -19,6 +19,8 @@
 final class PhabricatorProjectProfileEditController
   extends PhabricatorProjectController {
 
+  private $id;
+
   public function willProcessRequest(array $data) {
     $this->id = $data['id'];
   }

src/applications/xhpastview/controller/PhabricatorXHPASTViewPanelController.php

@@ -1,7 +1,7 @@
 <?php
 
 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -20,7 +20,7 @@ abstract class PhabricatorXHPASTViewPanelController
   extends PhabricatorXHPASTViewController {
 
   private $id;
-  private $tree;
+  private $storageTree;
 
   public function willProcessRequest(array $data) {
     $this->id = $data['id'];

src/view/layout/PhabricatorPinboardItemView.php

@@ -22,6 +22,8 @@ final class PhabricatorPinboardItemView extends AphrontView {
   private $uri;
   private $header;
 
+  private $imageWidth;
+  private $imageHeight;
 
   public function setHeader($header) {
     $this->header = $header;