mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-23 07:12:41 +01:00
Declare used properties
Summary: Also fix couple of other errors. Test Plan: Executed controllers. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D3627
This commit is contained in:
parent
84ddc4a0c9
commit
5bde6c71ce
11 changed files with 15 additions and 18 deletions
|
@ -121,11 +121,6 @@ class AphrontDefaultApplicationConfiguration
|
||||||
'' => 'DrydockResourceListController',
|
'' => 'DrydockResourceListController',
|
||||||
'resource/' => 'DrydockResourceListController',
|
'resource/' => 'DrydockResourceListController',
|
||||||
'resource/allocate/' => 'DrydockResourceAllocateController',
|
'resource/allocate/' => 'DrydockResourceAllocateController',
|
||||||
'host/' => array(
|
|
||||||
'' => 'DrydockHostListController',
|
|
||||||
'edit/' => 'DrydockHostEditController',
|
|
||||||
'edit/(?P<id>\d+)/' => 'DrydockhostEditController',
|
|
||||||
),
|
|
||||||
'lease/' => 'DrydockLeaseListController',
|
'lease/' => 'DrydockLeaseListController',
|
||||||
'log/' => 'DrydockLogController',
|
'log/' => 'DrydockLogController',
|
||||||
),
|
),
|
||||||
|
|
|
@ -19,6 +19,8 @@
|
||||||
final class PhabricatorOAuthDiagnosticsController
|
final class PhabricatorOAuthDiagnosticsController
|
||||||
extends PhabricatorAuthController {
|
extends PhabricatorAuthController {
|
||||||
|
|
||||||
|
private $provider;
|
||||||
|
|
||||||
public function shouldRequireLogin() {
|
public function shouldRequireLogin() {
|
||||||
return false;
|
return false;
|
||||||
}
|
}
|
||||||
|
|
|
@ -19,6 +19,8 @@
|
||||||
final class PhabricatorCountdownDeleteController
|
final class PhabricatorCountdownDeleteController
|
||||||
extends PhabricatorCountdownController {
|
extends PhabricatorCountdownController {
|
||||||
|
|
||||||
|
private $id;
|
||||||
|
|
||||||
public function willProcessRequest(array $data) {
|
public function willProcessRequest(array $data) {
|
||||||
$this->id = $data['id'];
|
$this->id = $data['id'];
|
||||||
}
|
}
|
||||||
|
|
|
@ -32,6 +32,8 @@ final class HeraldRule extends HeraldDAO {
|
||||||
|
|
||||||
private $ruleApplied = array(); // phids for which this rule has been applied
|
private $ruleApplied = array(); // phids for which this rule has been applied
|
||||||
private $invalidOwner = false;
|
private $invalidOwner = false;
|
||||||
|
private $conditions;
|
||||||
|
private $actions;
|
||||||
|
|
||||||
public static function loadAllByContentTypeWithFullData(
|
public static function loadAllByContentTypeWithFullData(
|
||||||
$content_type,
|
$content_type,
|
||||||
|
|
|
@ -20,6 +20,7 @@ final class HeraldRuleEditHistoryView extends AphrontView {
|
||||||
|
|
||||||
private $edits;
|
private $edits;
|
||||||
private $handles;
|
private $handles;
|
||||||
|
private $user;
|
||||||
|
|
||||||
public function setEdits(array $edits) {
|
public function setEdits(array $edits) {
|
||||||
$this->edits = $edits;
|
$this->edits = $edits;
|
||||||
|
|
|
@ -24,7 +24,6 @@ final class PonderFeedController extends PonderController {
|
||||||
|
|
||||||
public function willProcessRequest(array $data) {
|
public function willProcessRequest(array $data) {
|
||||||
$this->page = idx($data, 'page');
|
$this->page = idx($data, 'page');
|
||||||
$this->feedOffset = idx($data, 'feedoffset');
|
|
||||||
}
|
}
|
||||||
|
|
||||||
public function processRequest() {
|
public function processRequest() {
|
||||||
|
@ -81,14 +80,10 @@ final class PonderFeedController extends PonderController {
|
||||||
self::PROFILE_ANSWER_PAGE_SIZE + 1
|
self::PROFILE_ANSWER_PAGE_SIZE + 1
|
||||||
);
|
);
|
||||||
|
|
||||||
$phids = array($user->getPHID());
|
|
||||||
$handles = $this->loadViewerHandles($phids);
|
|
||||||
|
|
||||||
$side_nav->appendChild(
|
$side_nav->appendChild(
|
||||||
id(new PonderUserProfileView())
|
id(new PonderUserProfileView())
|
||||||
->setUser($user)
|
->setUser($user)
|
||||||
->setAnswers($answers)
|
->setAnswers($answers)
|
||||||
->setHandles($handles)
|
|
||||||
->setAnswerOffset($this->answerOffset)
|
->setAnswerOffset($this->answerOffset)
|
||||||
->setPageSize(self::PROFILE_ANSWER_PAGE_SIZE)
|
->setPageSize(self::PROFILE_ANSWER_PAGE_SIZE)
|
||||||
->setURI(new PhutilURI("/ponder/profile/"), "aoff")
|
->setURI(new PhutilURI("/ponder/profile/"), "aoff")
|
||||||
|
|
|
@ -50,11 +50,6 @@ final class PonderUserProfileView extends AphrontView {
|
||||||
return $this;
|
return $this;
|
||||||
}
|
}
|
||||||
|
|
||||||
public function setHandles($handles) {
|
|
||||||
$this->handles = $handles;
|
|
||||||
return $this;
|
|
||||||
}
|
|
||||||
|
|
||||||
public function setURI($uri, $aparam) {
|
public function setURI($uri, $aparam) {
|
||||||
$this->uri = $uri;
|
$this->uri = $uri;
|
||||||
$this->aparam = $aparam;
|
$this->aparam = $aparam;
|
||||||
|
@ -68,7 +63,6 @@ final class PonderUserProfileView extends AphrontView {
|
||||||
$user = $this->user;
|
$user = $this->user;
|
||||||
$aoffset = $this->answeroffset;
|
$aoffset = $this->answeroffset;
|
||||||
$answers = $this->answers;
|
$answers = $this->answers;
|
||||||
$handles = $this->handles;
|
|
||||||
$uri = $this->uri;
|
$uri = $this->uri;
|
||||||
$aparam = $this->aparam;
|
$aparam = $this->aparam;
|
||||||
$pagesize = $this->pagesize;
|
$pagesize = $this->pagesize;
|
||||||
|
|
|
@ -19,6 +19,8 @@
|
||||||
final class PhabricatorProjectMembersEditController
|
final class PhabricatorProjectMembersEditController
|
||||||
extends PhabricatorProjectController {
|
extends PhabricatorProjectController {
|
||||||
|
|
||||||
|
private $id;
|
||||||
|
|
||||||
public function willProcessRequest(array $data) {
|
public function willProcessRequest(array $data) {
|
||||||
$this->id = $data['id'];
|
$this->id = $data['id'];
|
||||||
}
|
}
|
||||||
|
|
|
@ -19,6 +19,8 @@
|
||||||
final class PhabricatorProjectProfileEditController
|
final class PhabricatorProjectProfileEditController
|
||||||
extends PhabricatorProjectController {
|
extends PhabricatorProjectController {
|
||||||
|
|
||||||
|
private $id;
|
||||||
|
|
||||||
public function willProcessRequest(array $data) {
|
public function willProcessRequest(array $data) {
|
||||||
$this->id = $data['id'];
|
$this->id = $data['id'];
|
||||||
}
|
}
|
||||||
|
|
|
@ -1,7 +1,7 @@
|
||||||
<?php
|
<?php
|
||||||
|
|
||||||
/*
|
/*
|
||||||
* Copyright 2011 Facebook, Inc.
|
* Copyright 2012 Facebook, Inc.
|
||||||
*
|
*
|
||||||
* Licensed under the Apache License, Version 2.0 (the "License");
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||||
* you may not use this file except in compliance with the License.
|
* you may not use this file except in compliance with the License.
|
||||||
|
@ -20,7 +20,7 @@ abstract class PhabricatorXHPASTViewPanelController
|
||||||
extends PhabricatorXHPASTViewController {
|
extends PhabricatorXHPASTViewController {
|
||||||
|
|
||||||
private $id;
|
private $id;
|
||||||
private $tree;
|
private $storageTree;
|
||||||
|
|
||||||
public function willProcessRequest(array $data) {
|
public function willProcessRequest(array $data) {
|
||||||
$this->id = $data['id'];
|
$this->id = $data['id'];
|
||||||
|
|
|
@ -22,6 +22,8 @@ final class PhabricatorPinboardItemView extends AphrontView {
|
||||||
private $uri;
|
private $uri;
|
||||||
private $header;
|
private $header;
|
||||||
|
|
||||||
|
private $imageWidth;
|
||||||
|
private $imageHeight;
|
||||||
|
|
||||||
public function setHeader($header) {
|
public function setHeader($header) {
|
||||||
$this->header = $header;
|
$this->header = $header;
|
||||||
|
|
Loading…
Reference in a new issue