1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-25 16:22:43 +01:00

Minor bug fix with PHUIInfoView

Summary: Custom icons here aren't being set. Also use more standard `tt` UI.

Test Plan: Set an icon, see set Icon.

Reviewers: epriestley

Reviewed By: epriestley

Spies: Korvin

Differential Revision: https://secure.phabricator.com/D18522
This commit is contained in:
Chad Little 2017-09-03 09:39:19 -07:00
parent 33b4de9acf
commit 5ceca721cc
3 changed files with 9 additions and 5 deletions

View file

@ -9,7 +9,7 @@ return array(
'names' => array( 'names' => array(
'conpherence.pkg.css' => 'e68cf1fa', 'conpherence.pkg.css' => 'e68cf1fa',
'conpherence.pkg.js' => 'b5b51108', 'conpherence.pkg.js' => 'b5b51108',
'core.pkg.css' => '9dd62a98', 'core.pkg.css' => '1071e7a2',
'core.pkg.js' => '6c085267', 'core.pkg.js' => '6c085267',
'darkconsole.pkg.js' => '1f9a31bc', 'darkconsole.pkg.js' => '1f9a31bc',
'differential.pkg.css' => '45951e9e', 'differential.pkg.css' => '45951e9e',
@ -163,7 +163,7 @@ return array(
'rsrc/css/phui/phui-icon-set-selector.css' => '87db8fee', 'rsrc/css/phui/phui-icon-set-selector.css' => '87db8fee',
'rsrc/css/phui/phui-icon.css' => '5c4a5de6', 'rsrc/css/phui/phui-icon.css' => '5c4a5de6',
'rsrc/css/phui/phui-image-mask.css' => 'a8498f9c', 'rsrc/css/phui/phui-image-mask.css' => 'a8498f9c',
'rsrc/css/phui/phui-info-view.css' => 'e1b4ec37', 'rsrc/css/phui/phui-info-view.css' => '04e071d7',
'rsrc/css/phui/phui-invisible-character-view.css' => '6993d9f0', 'rsrc/css/phui/phui-invisible-character-view.css' => '6993d9f0',
'rsrc/css/phui/phui-left-right.css' => '75227a4d', 'rsrc/css/phui/phui-left-right.css' => '75227a4d',
'rsrc/css/phui/phui-lightbox.css' => '0a035e40', 'rsrc/css/phui/phui-lightbox.css' => '0a035e40',
@ -851,7 +851,7 @@ return array(
'phui-icon-set-selector-css' => '87db8fee', 'phui-icon-set-selector-css' => '87db8fee',
'phui-icon-view-css' => '5c4a5de6', 'phui-icon-view-css' => '5c4a5de6',
'phui-image-mask-css' => 'a8498f9c', 'phui-image-mask-css' => 'a8498f9c',
'phui-info-view-css' => 'e1b4ec37', 'phui-info-view-css' => '04e071d7',
'phui-inline-comment-view-css' => '65ae3bc2', 'phui-inline-comment-view-css' => '65ae3bc2',
'phui-invisible-character-view-css' => '6993d9f0', 'phui-invisible-character-view-css' => '6993d9f0',
'phui-left-right-css' => '75227a4d', 'phui-left-right-css' => '75227a4d',

View file

@ -59,6 +59,7 @@ final class PHUIInfoView extends AphrontTagView {
} else { } else {
$icon = id(new PHUIIconView()) $icon = id(new PHUIIconView())
->setIcon($icon); ->setIcon($icon);
$this->icon = $icon;
} }
return $this; return $this;

View file

@ -46,8 +46,11 @@ div.phui-info-view.phui-info-severity-plain {
} }
.phui-info-view-body tt { .phui-info-view-body tt {
padding: 0 2px; color: {$blacktext};
background-color: rgba({$alphagrey},.1); background: rgba({$alphablue},0.1);
padding: 1px 4px;
border-radius: 3px;
white-space: pre-wrap;
} }
.phui-info-view-actions { .phui-info-view-actions {