revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-31 17:08:22 +01:00
Code Issues Releases Wiki Activity

Differential - fix "transaction has no effect error" on diff create

Browse source 
Summary: Fixes T6658.

Test Plan: made a diff with no repository and default policy and it worked!

Reviewers: epriestley, chad

Reviewed By: chad

Subscribers: Korvin, epriestley

Maniphest Tasks: T6658

Differential Revision: https://secure.phabricator.com/D10910
This commit is contained in:
Bob Trahan 2014-12-01 12:13:04 -08:00
parent 48e90ca7d5
commit 6081370391
2 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/applications/differential/conduit/DifferentialCreateDiffConduitAPIMethod.php
View file

@ -172,6 +172,7 @@ final class DifferentialCreateDiffConduitAPIMethod
id(new DifferentialDiffEditor()) id(new DifferentialDiffEditor())
->setActor($viewer) ->setActor($viewer)
->setContentSourceFromConduitRequest($request) ->setContentSourceFromConduitRequest($request)
->setContinueOnNoEffect(true)
->applyTransactions($diff, $xactions); ->applyTransactions($diff, $xactions);
$path = '/differential/diff/'.$diff->getID().'/'; $path = '/differential/diff/'.$diff->getID().'/';

1
src/applications/differential/conduit/DifferentialCreateRawDiffConduitAPIMethod.php
View file

@ -68,6 +68,7 @@ final class DifferentialCreateRawDiffConduitAPIMethod
id(new DifferentialDiffEditor()) id(new DifferentialDiffEditor())
->setActor($viewer) ->setActor($viewer)
->setContentSourceFromConduitRequest($request) ->setContentSourceFromConduitRequest($request)
->setContinueOnNoEffect(true)
->setLookupRepository(false) // respect user choice ->setLookupRepository(false) // respect user choice
->applyTransactions($diff, $xactions); ->applyTransactions($diff, $xactions);