Cast old duration values for unit tests to float in DifferentialController

Summary: Fixes T10549.

Test Plan: N/A

Reviewers: #blessed_reviewers, avivey, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin

Maniphest Tasks: T10549

Differential Revision: https://secure.phabricator.com/D15452

src/applications/differential/controller/DifferentialController.php

@@ -190,6 +190,12 @@ abstract class DifferentialController extends PhabricatorController {
       }
     }
 
+    // Cast duration to a float since it used to be a string in some
+    // cases.
+    if (isset($map['duration'])) {
+      $map['duration'] = (double)$map['duration'];
+    }
+
     return $map;
   }
 

src/applications/differential/controller/DifferentialRevisionViewController.php

@@ -1078,6 +1078,10 @@ final class DifferentialRevisionViewController extends DifferentialController {
       return null;
     }
 
+    if (!$diff->getBuildable()) {
+      return null;
+    }
+
     $interesting_messages = array();
     foreach ($diff->getUnitMessages() as $message) {
       switch ($message->getResult()) {