revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-23 14:00:56 +01:00
Code Issues Releases Wiki Activity

Set a URI on Auth Messages, so the "Change Details" dialog from the transaction record has a cancel button

Browse source 
Summary:
If you edit an auth message in Auth > Customize Messages, then click "Show Details" in the transaction record, the resulting dialog uses the object's handle's URI to generate a "cancel" button.

Since these handles currently have no URI, the dialog currently has no cancel/done button to close it.

Test Plan: Edited an auth message, clicked "Show Details", was now able to click "Done" to close the dialog.

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D20471
This commit is contained in:
epriestley 2019-04-25 08:08:56 -07:00
parent 6d13b9fb7a
commit 648d5ce190
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/applications/auth/phid/PhabricatorAuthMessagePHIDType.php
View file

@ -28,7 +28,11 @@ final class PhabricatorAuthMessagePHIDType extends PhabricatorPHIDType {
PhabricatorHandleQuery $query,
array $handles,
array $objects) {
return;
foreach ($handles as $phid => $handle) {
$message = $objects[$phid];
$handle->setURI($message->getURI());
}
}
}