revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-23 05:01:13 +01:00
Code Issues Releases Wiki Activity

Clarify that a PHUITagView API argument is boolean, not a value in "millimeters"

Browse source 
Summary:
See PHI454. Ref T13102. This parameter is not named as clearly as it could be.

This is a buff to API humor.

See also <https://secure.phabricator.com/differential/diff/46024/>.

Test Plan: Read API method, laughed aloud ("LAL") much harder because the humor was now less subtle. Subtle humor is unsuitable for this project.

Maniphest Tasks: T13102

Differential Revision: https://secure.phabricator.com/D19231
This commit is contained in:
epriestley 2018-03-16 13:03:36 -07:00
parent c216fd4072
commit 667955b8ae
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/view/phui/PHUITagView.php
View file

@ -117,8 +117,8 @@ final class PHUITagView extends AphrontTagView {
return $this;
}
public function setSlimShady($mm) {
$this->slimShady = $mm;
public function setSlimShady($is_eminem) {
$this->slimShady = $is_eminem;
return $this;
}