1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-29 10:12:41 +01:00

Updated .arclint in Phorge to exclude package-lock.json from Aphlict setup

Summary:
Aphlict requires a machine generated `package-lock.json` that can trigger linters unnecessarily.

This revision excludes it from all linters

Test Plan:
**Testing**

```name="Fake Change to set off the linter""
diff --git a/support/aphlict/server/package-lock.json b/support/aphlict/server/package-lock.json
index 8af62ae233..a417725182 100644
--- a/support/aphlict/server/package-lock.json
+++ b/support/aphlict/server/package-lock.json
@@ -2,11 +2,12 @@
   "name": "aphlict-server",
   "requires": true,
   "lockfileVersion": 1,
+  "testing" : true,
   "dependencies": {
     "ws": {
       "version": "7.5.0",
       "resolved": "https://registry.npmjs.org/ws/-/ws-7.5.0.tgz",
-      "integrity": "sha512-6ezXvzOZupqKj4jUqbQ9tXuJNo+BR2gU8fFRk3XCP3e0G6WT414u5ELe6Y0vtp7kmSJ3F7YWObSNr1ESsgi4vw=="
+      "integrity": "sha512-6ezXvzOZupqKj4jUqbQ9tXuJNo+BR2gU8fFRk3XCP3e0G6WT414u5ELe6Y0vtp7kmSJ3F7YWObSNr1ESsgasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfi4vw=="
     }
   }
 }
```

```name="arc lint results"
root@63c842bff39e:/srv/phorge/phorge# arc lint
>>> Lint for support/aphlict/server/package-lock.json:

   Warning  (TXT3) Line Too Long
    This line is 156 characters long, but the convention is 80 characters.

               7     "ws": {
               8       "version": "7.5.0",
               9       "resolved": "https://registry.npmjs.org/ws/-/ws-7.5.0.tgz",
    >>>       10       "integrity": "sha512-6ezXvzOZupqKj4jUqbQ9tXuJNo+BR2gU8fFRk3XCP3e0G6WT414u5ELe6Y0vtp7kmSJ3F7YWObSNr1ESsgasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfi4vw=="
              11     }
              12   }
              13 }
root@63c842bff39e:/srv/phorge/phorge#
```

Updated change

```name="Change to .arclint"
diff --git a/.arclint b/.arclint
index f215d93fdc..ca89c601e4 100644
--- a/.arclint
+++ b/.arclint
@@ -2,7 +2,8 @@
   "exclude": [
     "(^externals/)",
     "(^webroot/rsrc/externals/(?!javelin/))",
-    "(/__tests__/data/)"
+    "(/__tests__/data/)",
+    "(^support/aphlict/server/package-lock.json)"
   ],
   "linters": {
     "chmod": {
```

```name="arc lint results"
root@63c842bff39e:/srv/phorge/phorge# arc lint
 OKAY  No lint messages.
root@63c842bff39e:/srv/phorge/phorge#
```

Reviewers: O1 Blessed Committers, deadalnix, eax, speck

Reviewed By: O1 Blessed Committers, deadalnix, eax, speck

Subscribers: speck, tobiaswiese

Maniphest Tasks: T15021

Differential Revision: https://we.phorge.it/D25012
This commit is contained in:
ekubischta 2021-06-26 15:44:56 +00:00
parent e7740c8669
commit 69cb760921

View file

@ -2,7 +2,8 @@
"exclude": [ "exclude": [
"(^externals/)", "(^externals/)",
"(^webroot/rsrc/externals/(?!javelin/))", "(^webroot/rsrc/externals/(?!javelin/))",
"(/__tests__/data/)" "(/__tests__/data/)",
"(^support/aphlict/server/package-lock.json)"
], ],
"linters": { "linters": {
"chmod": { "chmod": {