revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-04-09 19:08:40 +02:00
Code Issues Releases Wiki Activity

Make grammar more consistent

Browse source 
Summary: In Maniphest, we say "X closed <task> by committing <commit>". In Differential, we currently say "X closed <revision> by commit <commit>", which sounds nongrammatical to me.

Test Plan: grammar'd

Reviewers: btrahan, chad

Reviewed By: chad

Subscribers: epriestley

Differential Revision: https://secure.phabricator.com/D11544
This commit is contained in:
epriestley 2015-01-28 12:52:58 -08:00
parent 4d6aea7ce8
commit 6a0fb7c37f
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/applications/differential/storage/DifferentialTransaction.php
View file

@ -393,14 +393,14 @@ final class DifferentialTransaction extends PhabricatorApplicationTransaction {
if ($committer_name && ($committer_name != $author_name)) { if ($committer_name && ($committer_name != $author_name)) {
return pht( return pht(
'%s closed %s by commit %s (authored by %s).', '%s closed %s by committing %s (authored by %s).',
$author_link, $author_link,
$object_link, $object_link,
$commit_name, $commit_name,
$author_name); $author_name);
} else { } else {
return pht( return pht(
'%s closed %s by commit %s.', '%s closed %s by committing %s.',
$author_link, $author_link,
$object_link, $object_link,
$commit_name); $commit_name);