1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-22 21:40:55 +01:00

Revert D4359 and apply a better fix

Summary:
In D4359 I fixed an error with 'lint' in SVN repositories, but created an error with the 'lint' column in Javascript. Specifically, when we load the column information over Ajax, we now always include a 'lint' key, even if there is no lint column.

Instead, access the 'lint' property conditionally (so SVN works) but don't include the key if there's no data (so Javascript works).

Test Plan: Loaded SVN, non-SVN non-lint, non-SVN+lint repositories. Everything appeared to work correctly.

Reviewers: asherkin, codeblock

Reviewed By: codeblock

CC: aran

Differential Revision: https://secure.phabricator.com/D4578
This commit is contained in:
epriestley 2013-01-22 12:26:52 -08:00
parent 35d73414f8
commit 70a2a653ff

View file

@ -72,7 +72,6 @@ final class DiffusionBrowseTableView extends DiffusionView {
'time' => $time,
'author' => $author,
'details' => $details,
'lint' => null,
);
$lint = self::loadLintMessagesCount($drequest);
@ -218,7 +217,7 @@ final class DiffusionBrowseTableView extends DiffusionView {
$this->linkHistory($base_path.$path->getPath().$dir_slash),
$editor_button,
$browse_link,
$dict['lint'],
idx($dict, 'lint'),
$dict['commit'],
$dict['date'],
$dict['time'],