1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-23 22:10:55 +01:00

Fix a transaction editor "continue;" inside "switch()" for PHP 7.3

Summary: See <https://discourse.phabricator-community.org/t/new-git-commit-processing-fails-on-php-7-3/>. This "continue" should be a "break".

Test Plan:
{F6045490}

  - Tried to assign a task to myself while I was already the owner, got an appropriate error.

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D19844
This commit is contained in:
epriestley 2018-12-04 05:50:54 -08:00
parent 9bfe558587
commit 70bf63bc3a

View file

@ -649,7 +649,7 @@ final class ManiphestTransactionEditor
$old_value = $object->getOwnerPHID();
$new_value = $xaction->getNewValue();
if ($old_value === $new_value) {
continue;
break;
}
// When a task is reassigned, move the old owner to the subscriber