revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-26 16:52:41 +01:00
Code Issues Releases Wiki Activity

Fix a transaction editor "continue;" inside "switch()" for PHP 7.3

Browse source 
Summary: See <https://discourse.phabricator-community.org/t/new-git-commit-processing-fails-on-php-7-3/>. This "continue" should be a "break".

Test Plan:
{F6045490}

  - Tried to assign a task to myself while I was already the owner, got an appropriate error.

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D19844
This commit is contained in:
epriestley 2018-12-04 05:50:54 -08:00
parent 9bfe558587
commit 70bf63bc3a
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/maniphest/editor/ManiphestTransactionEditor.php
View file

@ -649,7 +649,7 @@ final class ManiphestTransactionEditor
$old_value = $object->getOwnerPHID(); $old_value = $object->getOwnerPHID();
$new_value = $xaction->getNewValue(); $new_value = $xaction->getNewValue();
if ($old_value === $new_value) { if ($old_value === $new_value) {
continue; break;
} }
// When a task is reassigned, move the old owner to the subscriber // When a task is reassigned, move the old owner to the subscriber