revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-28 00:10:57 +01:00
Code Issues Releases Wiki Activity

[Redesign] Clean up borders on ObjectItems

Browse source 
Summary: Ref T8099. A wild border appears!

Test Plan: Remove border when `barColor` is present. Test workboards and Maniphest.

Reviewers: btrahan, epriestley

Reviewed By: epriestley

Subscribers: epriestley, Korvin

Maniphest Tasks: T8099

Differential Revision: https://secure.phabricator.com/D13494
This commit is contained in:
Chad Little 2015-06-30 15:24:07 -07:00
parent d595faf7b7
commit 70d5e82253
3 changed files with 12 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
resources/celerity/map.php
View file

@ -7,7 +7,7 @@
*/
return array(
'names' => array(
'core.pkg.css' => '53a0131b',
'core.pkg.css' => '92a58b45',
'core.pkg.js' => 'a590b451',
'darkconsole.pkg.js' => 'e7393ebb',
'differential.pkg.css' => 'cf384ffa',
@ -141,7 +141,7 @@ return array(
'rsrc/css/phui/phui-info-view.css' => '5b16bac6',
'rsrc/css/phui/phui-list.css' => '02ab3534',
'rsrc/css/phui/phui-object-box.css' => '3db9f358',
'rsrc/css/phui/phui-object-item-list-view.css' => '2b126bca',
'rsrc/css/phui/phui-object-item-list-view.css' => '0053b016',
'rsrc/css/phui/phui-pager.css' => 'bea33d23',
'rsrc/css/phui/phui-pinboard-view.css' => '2495140e',
'rsrc/css/phui/phui-property-list-view.css' => '1baf23eb',
@ -785,7 +785,7 @@ return array(
'phui-inline-comment-view-css' => 'e862e60b',
'phui-list-view-css' => '02ab3534',
'phui-object-box-css' => '3db9f358',
'phui-object-item-list-view-css' => '2b126bca',
'phui-object-item-list-view-css' => '0053b016',
'phui-pager-css' => 'bea33d23',
'phui-pinboard-view-css' => '2495140e',
'phui-property-list-view-css' => '1baf23eb',

2
src/view/phui/PHUIObjectItemView.php
View file

@ -268,6 +268,8 @@ final class PHUIObjectItemView extends AphrontTagView {
if ($this->barColor) {
$item_classes[] = 'phui-object-item-bar-color-'.$this->barColor;
} else {
$item_classes[] = 'phui-object-item-no-bar';
}
if ($this->actions) {

8
webroot/rsrc/css/phui/phui-object-item-list-view.css
View file

@ -48,12 +48,18 @@ ul.phui-object-item-list-view {
}
.phui-object-item-frame {
border: 1px solid {$lightgreyborder};
border-color: {$lightblueborder};
border-width: 1px 1px 1px 0;
border-style: solid;
position: relative;
min-height: 33px;
overflow: hidden;
}
.phui-object-item-no-bar .phui-object-item-frame {
border-width: 1px;
}
.device-desktop .phui-object-item {
margin: 0 0 4px 0;
}