revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-09-20 01:08:50 +02:00
Code Issues Releases Wiki Activity

Empty list filters won't display if empty

Browse source 
Summary: Exactly what it says on the tin

Test Plan: No shadow when visiting saved custom queries in Maniphest. Still appears normally for other use sites

Reviewers: epriestley, chad

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D5535
This commit is contained in:
Anh Nhan Nguyen 2013-04-02 08:58:13 -07:00 committed by epriestley
parent bb5cc76b55
commit 70e0deb368
2 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/__celerity_resource_map__.php
View file

@ -1253,7 +1253,7 @@ celerity_register_resource_map(array(
), ),
'javelin-behavior-conpherence-menu' => 'javelin-behavior-conpherence-menu' =>
array( array(
'uri' => '/res/08fcd75a/rsrc/js/application/conpherence/behavior-menu.js', 'uri' => '/res/35811cd4/rsrc/js/application/conpherence/behavior-menu.js',
'type' => 'js', 'type' => 'js',
'requires' => 'requires' =>
array( array(

8
src/view/layout/AphrontListFilterView.php
View file

@ -3,6 +3,12 @@
final class AphrontListFilterView extends AphrontView { final class AphrontListFilterView extends AphrontView {
public function render() { public function render() {
$contents = $this->renderChildren();
if (!$contents) {
return null;
}
require_celerity_resource('aphront-list-filter-view-css'); require_celerity_resource('aphront-list-filter-view-css');
return hsprintf( return hsprintf(
'<div class="aphront-filter-table-wrapper">'. '<div class="aphront-filter-table-wrapper">'.
@ -12,7 +18,7 @@ final class AphrontListFilterView extends AphrontView {
'</tr>'. '</tr>'.
'</table>'. '</table>'.
'</div>', '</div>',
$this->renderChildren()); $contents);
} }
} }